Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.h

Issue 2192333002: [DevTools] Remove & add required methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.h b/third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.h
index a7d3d6b2d2eda178b68716ce5e55592fe8d688e0..2d795eb44edbca2a49a8411a31a1dc04b772fa23 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.h
@@ -36,7 +36,6 @@ public:
void notifyContextDestroyed();
private:
- bool callingContextCanAccessContext(v8::Local<v8::Context> calling, v8::Local<v8::Context> target) override;
String16 valueSubtype(v8::Local<v8::Value>) override;
bool formatAccessorsAsProperties(v8::Local<v8::Value>) override;
void muteWarningsAndDeprecations(int) override { }
@@ -45,6 +44,8 @@ private:
bool isExecutionAllowed() override;
v8::Local<v8::Context> ensureDefaultContextInGroup(int contextGroupId) override;
+ void beginEnsureAllContextsInGroup(int contextGroupId) override { }
+ void endEnsureAllContextsInGroup(int contextGroupId) override { }
void beginUserGesture() override { }
void endUserGesture() override { }
bool isInspectableHeapObject(v8::Local<v8::Object>) override { return true; }
@@ -63,8 +64,6 @@ private:
void cancelTimer(void* data) override { }
// V8InspectorSessionClient
- void runtimeEnabled() override { };
- void runtimeDisabled() override { };
void resumeStartup() override { };
bool canExecuteScripts() override;
void profilingStarted() override { };
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698