Add enable_vr_shell build time flag and show icon in Daydream app luncher

Add enable_vr_shell build time flag and show icon in Daydream app luncher

This CL adds enable_vr_shell build time flag. Once enabled, a Chromium icon will
appear in Daydream app luncher. The design of icon is still TBD.

BUG=617946
Committed: https://crrev.com/09668775e4444502eb38f0253b80be94f2245440
Cr-Commit-Position: refs/heads/master@{#409576}

[bshe, 2016-07-29 20:24:39]

bshe@chromium.org changed reviewers:
+ yfriedman@chromium.org

[bshe, 2016-07-29 20:24:40]

Hi Yaron.

Do you mind to take a look at this CL? Currently, enable_vr_shell is only apply
to Android. Currently, we only use the flag to let Chrome show an icon in
daydream's app launcher.

Thanks!

Biao

[bshe, 2016-08-02 21:09:04]

bshe@chromium.org changed reviewers:
+ tedchoc@chromium.org
- yfriedman@chromium.org

[bshe, 2016-08-02 21:09:04]

+tedchoc
Hi Ted. Do you mind take a look at this CL? It looks like Yaron is OOO. 
-Yaron

Thanks!

[Ted C, 2016-08-02 21:38:11]

https://codereview.chromium.org/2192243002/diff/1/chrome/common/features.gni
File chrome/common/features.gni (right):

https://codereview.chromium.org/2192243002/diff/1/chrome/common/features.gni#...
chrome/common/features.gni:36: enable_vr_shell = false && is_android
umm...while my gn foo is quite weak, this looks particularly odd to me.  why
isn't it just false?

[bshe, 2016-08-02 22:26:59]

https://codereview.chromium.org/2192243002/diff/1/chrome/common/features.gni
File chrome/common/features.gni (right):

https://codereview.chromium.org/2192243002/diff/1/chrome/common/features.gni#...
chrome/common/features.gni:36: enable_vr_shell = false && is_android
Good question. I was trying to restrice other platforms use this build flag as
we only support Android initially. And I think I can mix default value with
value of "is_android". "gn args --list out/Debug | grep vr_shell" shows that the
default value is "false" without "is_android" included. So I imagine when
processing it, false is replaced with the value we set in gn args first and then
evaluated here. But I am not 100% sure
Anyway, I agree this is not very readable and we dont use it outside of Android
anyway. So remove "is_android" here.

[bshe, 2016-08-02 22:31:47]

On 2016/08/02 22:26:59, bshe wrote:
> https://codereview.chromium.org/2192243002/diff/1/chrome/common/features.gni
> File chrome/common/features.gni (right):
> 
>
https://codereview.chromium.org/2192243002/diff/1/chrome/common/features.gni#...
> chrome/common/features.gni:36: enable_vr_shell = false && is_android
> Good question. I was trying to restrice other platforms use this build flag as
> we only support Android initially. And I think I can mix default value with
> value of "is_android". "gn args --list out/Debug | grep vr_shell" shows that
the
> default value is "false" without "is_android" included. So I imagine when
> processing it, false is replaced with the value we set in gn args first and
then
> evaluated here. But I am not 100% sure
> Anyway, I agree this is not very readable and we dont use it outside of
Android
> anyway. So remove "is_android" here.

huh. Look at the default value of other flags, it is either true or false. So I
suspect I understand it wrong. And you are right,
it should just set to false.

[Ted C, 2016-08-02 23:42:11]

lgtm

[bshe, 2016-08-03 00:18:20]

The CQ bit was checked by bshe@chromium.org

[commit-bot: I haz the power, 2016-08-03 00:19:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 00:40:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 00:40:15]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[bshe, 2016-08-03 15:13:14]

The CQ bit was checked by bshe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 15:13:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 16:59:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 16:59:16]

Dry run: This issue passed the CQ dry run.

[bshe, 2016-08-03 18:00:00]

On 2016/08/03 00:40:15, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

Hi Ted. Do you mind to take a look again. Previous patch failed on CQ because
enable_vr_shell wasn't defined
for some bots. In the latest patch, I have change it to the same way how
"enable_leakcanary" works. This is better
as we can now use the variable in test and a few other build target too.
Thanks!

Biao

[Ted C, 2016-08-03 18:16:13]

lgtm

[bshe, 2016-08-03 18:25:24]

The CQ bit was checked by bshe@chromium.org

[commit-bot: I haz the power, 2016-08-03 18:26:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 18:33:33]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-03 18:35:38]

Description was changed from

==========
Add enable_vr_shell build time flag and show icon in Daydream app luncher

This CL adds enable_vr_shell build time flag. Once enabled, a Chromium icon will
appear in Daydream app luncher. The design of icon is still TBD.

BUG=617946
==========

to

==========
Add enable_vr_shell build time flag and show icon in Daydream app luncher

This CL adds enable_vr_shell build time flag. Once enabled, a Chromium icon will
appear in Daydream app luncher. The design of icon is still TBD.

BUG=617946

Committed: https://crrev.com/09668775e4444502eb38f0253b80be94f2245440
Cr-Commit-Position: refs/heads/master@{#409576}
==========

[commit-bot: I haz the power, 2016-08-03 18:35:40]

Patchset 3 (id:??) landed as
https://crrev.com/09668775e4444502eb38f0253b80be94f2245440
Cr-Commit-Position: refs/heads/master@{#409576}