Make git recipe api add depot_tools to PATH

Make git recipe api add depot_tools to PATH

"git retry" assumes that depot_tools is in PATH; in some cases it isn't,
and there's currently no way to add it.

BUG=

Recipe-Tryjob-Bypass-Reason: Expectations known to change
Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/9d5696da808ea15566621747b8e8053b07eac0f2

[borenet, 2016-07-29 12:32:12]

borenet@google.com changed reviewers:
+ borenet@google.com, nodir@chromium.org, phajdan.jr@chromium.org

[borenet, 2016-07-29 12:32:12]

A (probably better) alternative would be to have recipe_modules which live in
depot_tools and depend on things in the depot_tools repo just add depot_tools to
PATH themselves.

[nodir, 2016-07-29 15:45:07]

On 2016/07/29 12:32:12, borenet wrote:
> A (probably better) alternative would be to have recipe_modules which live in
> depot_tools and depend on things in the depot_tools repo just add depot_tools
to
> PATH themselves.

moreover there is already a module for things like that
https://cs.chromium.org/chromium/tools/depot_tools/recipe_modules/depot_tools...

[borenet, 2016-07-29 16:54:08]

On 2016/07/29 15:45:07, nodir wrote:
> On 2016/07/29 12:32:12, borenet wrote:
> > A (probably better) alternative would be to have recipe_modules which live
in
> > depot_tools and depend on things in the depot_tools repo just add
depot_tools
> to
> > PATH themselves.
> 
> moreover there is already a module for things like that
>
https://cs.chromium.org/chromium/tools/depot_tools/recipe_modules/depot_tools...

Ah, I didn't know that existed.  Used that to add to PATH in patch set 2.  PTAL.

[nodir, 2016-07-29 17:41:50]

lgtm

https://codereview.chromium.org/2192163002/diff/20001/recipe_modules/git/api.py
File recipe_modules/git/api.py (right):

https://codereview.chromium.org/2192163002/diff/20001/recipe_modules/git/api....
recipe_modules/git/api.py:213: str(self.package_repo_resource()), '%(PATH)s'])
does %(PATH)s work? I don't know what expands it

[borenet, 2016-07-29 18:56:02]

https://codereview.chromium.org/2192163002/diff/20001/recipe_modules/git/api.py
File recipe_modules/git/api.py (right):

https://codereview.chromium.org/2192163002/diff/20001/recipe_modules/git/api....
recipe_modules/git/api.py:213: str(self.package_repo_resource()), '%(PATH)s'])
On 2016/07/29 17:41:50, nodir wrote:
> does %(PATH)s work? I don't know what expands it

Yeah, must be the recipe engine.  We use it in a couple of other places where
just overriding PATH would not work, eg.
https://skia.googlesource.com/skia/+/master/infra/bots/recipes/swarm_Recreate...

[borenet, 2016-07-29 18:56:13]

The CQ bit was checked by borenet@google.com

[commit-bot: I haz the power, 2016-07-29 18:56:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 19:02:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 19:02:33]

Try jobs failed on following builders:
  Recipe Roll Downstream Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/3050d56d60720b10)

[borenet, 2016-08-01 12:44:20]

On 2016/07/29 19:02:33, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   Recipe Roll Downstream Tester on luci.infra.try (JOB_FAILED,
> https://luci-milo.appspot.com/swarming/task/3050d56d60720b10)

How do I fix this?  I expected recipe simulation diffs since this changes the
environment for all users of this recipe module.

[borenet, 2016-08-01 12:44:47]

Description was changed from

==========
Add optional environment override to git recipe api

"git retry" assumes that depot_tools is in PATH; in some cases it isn't,
and there's currently no way to add it.

BUG=
==========

to

==========
Make git recipe api add depot_tools to PATH

"git retry" assumes that depot_tools is in PATH; in some cases it isn't,
and there's currently no way to add it.

BUG=
==========

[nodir, 2016-08-01 15:52:06]

nodir@chromium.org changed reviewers:
+ martiniss@chromium.org

[nodir, 2016-08-01 15:52:07]

+martiniss

don't know. I don't see instructions how to process in this case in this CL or
on a page reachable by links from this CL.

[Dirk Pranke, 2016-08-01 16:00:06]

See
https://chromium.googlesource.com/external/github.com/luci/recipes-py.git/+/H...
, I think.

[martiniss, 2016-08-01 18:32:25]

On 2016/08/01 at 16:00:06, dpranke wrote:
> See
https://chromium.googlesource.com/external/github.com/luci/recipes-py.git/+/H...
, I think.

Yes; that gives you instructions on what to do. You should be able to add

Recipe-Tryjob-Bypass-Reason: Expectations known to change

to the description, and the tryjob should pass fine. I'll do this now and double
check that it's working.

[martiniss, 2016-08-01 18:32:33]

Description was changed from

==========
Make git recipe api add depot_tools to PATH

"git retry" assumes that depot_tools is in PATH; in some cases it isn't,
and there's currently no way to add it.

BUG=
==========

to

==========
Make git recipe api add depot_tools to PATH

"git retry" assumes that depot_tools is in PATH; in some cases it isn't,
and there's currently no way to add it.

BUG=

Recipe-Tryjob-Bypass-Reason: Expectations known to change
==========

[martiniss, 2016-08-01 18:32:49]

The CQ bit was checked by martiniss@chromium.org

[commit-bot: I haz the power, 2016-08-01 18:33:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 18:36:20]

Description was changed from

==========
Make git recipe api add depot_tools to PATH

"git retry" assumes that depot_tools is in PATH; in some cases it isn't,
and there's currently no way to add it.

BUG=

Recipe-Tryjob-Bypass-Reason: Expectations known to change
==========

to

==========
Make git recipe api add depot_tools to PATH

"git retry" assumes that depot_tools is in PATH; in some cases it isn't,
and there's currently no way to add it.

BUG=

Recipe-Tryjob-Bypass-Reason: Expectations known to change
Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/9d5696da808ea1...
==========

[commit-bot: I haz the power, 2016-08-01 18:36:21]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/9d5696da808ea1...

[borenet, 2016-08-01 18:41:44]

Thanks guys. Here's hoping this doesn't break everything :)