Make git recipe api add depot_tools to PATH

recipe_modules/git/api.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import itertools
 import re
 
 from recipe_engine import recipe_api
 
 class GitApi(recipe_api.RecipeApi):
@@ skipping 190 matching lines @@
       self.ensure_win_git_tooling()
       git_setup_args += [
           '--git_cmd_path', self.package_repo_resource('git.bat')]
 
     step_suffix = '' if step_suffix is  None else ' (%s)' % step_suffix
     self.m.python(
         'git setup%s' % step_suffix,
         self.resource('git_setup.py'),
         git_setup_args)
 
+    # Some of the commands below require depot_tools to be in PATH.
+    path = self.m.path.pathsep.join([
+        str(self.package_repo_resource()), '%(PATH)s'])

[nodir, 2016/07/29 17:41:50]

does %(PATH)s work? I don't know what expands it

[borenet, 2016/07/29 18:56:01]

Yeah, must be the recipe engine.  We use it in a couple of other places where
just overriding PATH would not work, eg.
https://skia.googlesource.com/skia/+/master/infra/bots/recipes/swarm_Recreate...

+
     if use_git_cache:
       self('retry', 'cache', 'fetch', '-c', self.m.path['git_cache'],
            cwd=dir_path,
            name='fetch cache',
-           can_fail_build=can_fail_build)
+           can_fail_build=can_fail_build,
+           env={'PATH': path})
 
     # There are five kinds of refs we can be handed:
     # 0) None. In this case, we default to properties['branch'].
     # 1) A 40-character SHA1 hash.
     # 2) A fully-qualifed arbitrary ref, e.g. 'refs/foo/bar/baz'.
     # 3) A fully qualified branch name, e.g. 'refs/heads/master'.
     #    Chop off 'refs/heads' and now it matches case (4).
     # 4) A branch name, e.g. 'master'.
     # Note that 'FETCH_HEAD' can be many things (and therefore not a valid
     # checkout target) if many refs are fetched, but we only explicitly fetch
@@ skipping 13 matching lines @@
       checkout_ref = 'FETCH_HEAD'
     else:                                     # Cases 2 and 4.
       fetch_remote = remote_name
       fetch_ref = ref
       checkout_ref = 'FETCH_HEAD'
 
     fetch_args = [x for x in (fetch_remote, fetch_ref) if x]
     if recursive:
       fetch_args.append('--recurse-submodules')
 
-    fetch_env = {}
+    fetch_env = {'PATH': path}
     fetch_stderr = None
     if curl_trace_file:
       fetch_env['GIT_CURL_VERBOSE'] = '1'
       fetch_stderr = self.m.raw_io.output(leak_to=curl_trace_file)
 
     fetch_step_name = 'git fetch%s' % step_suffix
     if display_fetch_size:
       count_objects_before_fetch = self.count_objects(
           name='count-objects before %s' % fetch_step_name,
           cwd=dir_path,
@@ skipping 124 matching lines @@
 
     Args:
       bundle_path (Path): The path of the output bundle.
       refs (list): The list of refs to include in the bundle. If None, all
           refs in the Git checkout will be bundled.
       kwargs: Forwarded to '__call__'.
     """
     if not rev_list_args:
       rev_list_args = ['--all']
     self('bundle', 'create', bundle_path, *rev_list_args, **kwargs)