Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: chrome/common/extensions/docs/templates/articles/app_codelab5_data.html

Issue 219213007: Remove .html extension from links (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/docs/templates/articles/app_codelab5_data.html
diff --git a/chrome/common/extensions/docs/templates/articles/app_codelab5_data.html b/chrome/common/extensions/docs/templates/articles/app_codelab5_data.html
index 73e0fea94b72d3b39fdf51ba43ce1703454ec276..68da2b38c0bb2d52df9897a2e09283336968fc5a 100644
--- a/chrome/common/extensions/docs/templates/articles/app_codelab5_data.html
+++ b/chrome/common/extensions/docs/templates/articles/app_codelab5_data.html
@@ -1,11 +1,11 @@
<h1 id="lab_5_manage_data">Save and Fetch Data</h1>
-<p>The <a href="app_codelab3_mvc.html">sample from Lab 3</a>
+<p>The <a href="app_codelab3_mvc">sample from Lab 3</a>
uses a static array of Todos.
Every time your app restarts,
whatever you&#39;ve changed is lost.
In this section, we will save every change using
-<a href="storage.html">chrome.storage.sync</a>.
+<a href="storage">chrome.storage.sync</a>.
</p>
<p>
@@ -115,8 +115,8 @@ $scope.save = function() {
<h3 id="simple-view">Update view</h3>
<p>In the view,
-<a href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab5_data/angularjs/1_storage_sync/index.html">AngularJs index.hmtl</a> or
-<a href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab5_data/javascript/1_storage_sync/index.html">JavaScript index.html</a>,
+<a href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab5_data/angularjs/1_storage_sync/index">AngularJs index.hmtl</a> or
mkearney1 2014/04/09 19:43:29 Check if GitHub links work without .html
mkearney1 2014/04/09 19:43:29 Keep .html here as it refers to a filename in a sa
+<a href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab5_data/javascript/1_storage_sync/index">JavaScript index</a>,
save the data whenever it changes.
In AngularJS,
we call <code>save()</code> explicitedly
@@ -131,7 +131,7 @@ you could also use <code>$watchers</code> on the scope.
<header tabindex="0" data-value="js">JavaScript</header>
<content>
- <pre data-filename="index.html">
+ <pre data-filename="index">
mkearney1 2014/04/09 19:43:29 Keep .html here as it refers to a filename in samp
...
[ &lt;a href=&quot;&quot; ng-click=&quot;archive() || save()&quot;&gt;archive&lt;/a&gt; ]
...
@@ -142,7 +142,7 @@ you could also use <code>$watchers</code> on the scope.
</pre>
</content>
<content>
- <pre data-filename="index.html">
+ <pre data-filename="index">
mkearney1 2014/04/09 19:43:29 Keep .html here as it refers to a filename in samp
&lt;form&gt;
&lt;input type="text" size="30"
placeholder="add new todo here"&gt;
@@ -322,7 +322,7 @@ exports.setDragHandlers = function(model) {
<p>If using AngularJS,
let&#39;s move the Angular scope definition from the div to the body in the
-<a href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab5_data/angularjs/2_drop_files/index.html">AngularJS index.html</a> file to make all the area of the window accept the drop event and still work on the same scope.
+<a href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab5_data/angularjs/2_drop_files/index">AngularJS index</a> file to make all the area of the window accept the drop event and still work on the same scope.
mkearney1 2014/04/09 19:43:29 Check links work to GitHub samples without .html.
mkearney1 2014/04/09 19:43:29 Keep .html here as it refers to filename in sample
Also, let&#39;s associate the body&#39;s CSS class with the Angular controller&#39;s class,
so we can change the class directly in the scope and have it automatically changed in the DOM:
</p>
@@ -332,7 +332,7 @@ so we can change the class directly in the scope and have it automatically chang
<header tabindex="0" data-value="angular">Angular</header>
<content>
- <pre data-filename="index.html">
+ <pre data-filename="index">
&lt;body ng-controller=&quot;TodoCtrl&quot; ng-class=&quot;dropClass&quot;&gt;
&lt;!-- remember to remove the ng-controller attribute from the div where it was before --&gt;
</pre>
@@ -341,8 +341,8 @@ so we can change the class directly in the scope and have it automatically chang
</tabs>
<p>Add a message placeholder
-(in <a href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab5_data/angularjs/2_drop_files/index.html">AngularJS index.html</a> or
-<a href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab5_data/javascript/2_drop_files/index.html">JavaScript index.html</a>) to warn the user that some types of dragging are not allowed:
+(in <a href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab5_data/angularjs/2_drop_files/index">AngularJS index</a> or
mkearney1 2014/04/09 19:43:29 Check this link works without .html.
mkearney1 2014/04/09 19:43:29 Keep this .html in as it refers to a filename in s
+<a href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab5_data/javascript/2_drop_files/index">JavaScript index</a>) to warn the user that some types of dragging are not allowed:
mkearney1 2014/04/09 19:43:29 Check this link works without .html.
mkearney1 2014/04/09 19:43:29 Keep .html in as it refers to a filename in sample
</p>
<tabs data-group="source">
@@ -351,14 +351,14 @@ so we can change the class directly in the scope and have it automatically chang
<header tabindex="0" data-value="js">JavaScript</header>
<content>
- <pre data-filename="index.html">
+ <pre data-filename="index">
mkearney1 2014/04/09 19:43:29 Keep .html in as it refers to filename in sample.
&lt;div&gt;
&#123;&#123;dropText&#125;&#125;
&lt;/div&gt;
</pre>
</content>
<content>
- <pre data-filename="index.html">
+ <pre data-filename="index">
mkearney1 2014/04/09 19:43:29 Keep .html in as it refers to filename in sample.
&lt;div id=&quot;dropText&quot;&gt;
&lt;/div&gt;
</pre>
@@ -407,26 +407,26 @@ or <a href="https://github.com/GoogleChrome/chrome-app-codelab/tree/master/lab5_
<h2 id="challenge_">Challenge</h2>
-<p>The current code only saves the file reference, but it doesn&#39;t open the file. Using the <a href="http://www.html5rocks.com/en/tutorials/file/filesystem/">HTML5 Filesystem API</a>, save the file contents in a sandboxed filesystem. When the Todo item is archived, remove the corresponding file from the sandboxed filesystem. Add an &quot;open&quot; link on each Todo that has an associated file. When the item is clicked and the file exists in the sandboxed filesystem, use the Chrome App <a href="fileSystem.html">Filesystem API</a> to request a writable FileEntry from the user. Save the file data from the sandboxed filesystem into that entry.</p>
+<p>The current code only saves the file reference, but it doesn&#39;t open the file. Using the <a href="http://www.html5rocks.com/en/tutorials/file/filesystem/">HTML5 Filesystem API</a>, save the file contents in a sandboxed filesystem. When the Todo item is archived, remove the corresponding file from the sandboxed filesystem. Add an &quot;open&quot; link on each Todo that has an associated file. When the item is clicked and the file exists in the sandboxed filesystem, use the Chrome App <a href="fileSystem">Filesystem API</a> to request a writable FileEntry from the user. Save the file data from the sandboxed filesystem into that entry.</p>
<p class="note"><b>Tip:</b> managing file entries using the raw HTML5 Filesystem API is not trivial. You might want to use a wrapper library, like Eric Bidelman&#39;s <a href="https://github.com/ebidel/filer.js">filer.js</a>.</p>
<h2 id="takeaways_">Takeaways</h2>
<ul>
-<li><p>Use <a href="storage.html">chrome.storage.sync</a> to save small data that you need to be sync&#39;ed among devices, like configuration options, application state, etc. The sync is automatic, as long as the same user is logged into Chrome on all devices.</p></li>
+<li><p>Use <a href="storage">chrome.storage.sync</a> to save small data that you need to be sync&#39;ed among devices, like configuration options, application state, etc. The sync is automatic, as long as the same user is logged into Chrome on all devices.</p></li>
<li><p>Chrome Apps support almost all HTML5 APIs, such as drag and drop.
HTML Filesystem API is also supported, with extra features from the Chrome App&#39;s
-<a href="fileSystem.html">Filesystem API</a>,
+<a href="fileSystem">Filesystem API</a>,
like asking the user to pick files on her local disk for read and write.
The vanilla HTML5 Filesystem API only allows access to a sandboxed filesystem.</p></li>
</ul>
<h2 id="you_should_also_read">You should also read</h2>
-<p><a href="app_storage.html">Manage Data</a> tutorial</p>
+<p><a href="app_storage">Manage Data</a> tutorial</p>
<h2 id="what_39_s_next_">What's next?</h2>
-<p>In <a href="app_codelab6_lifecycle.html">5 - Manage App Lifecycle</a>,
+<p>In <a href="app_codelab6_lifecycle">5 - Manage App Lifecycle</a>,
you will learn the basics of the Chrome App lifecycle. </p>

Powered by Google App Engine
This is Rietveld 408576698