Chromium Code Reviews Chromium Code Reviews
Issue 219213007:
Remove .html extension from links (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: chrome/common/extensions/docs/templates/articles/app_codelab3_mvc.html |
| diff --git a/chrome/common/extensions/docs/templates/articles/app_codelab3_mvc.html b/chrome/common/extensions/docs/templates/articles/app_codelab3_mvc.html |
| index 6a22f9c905a7bd5fb3d207167da83f1ddc365e95..64705ac1ddfcdf2ee6471af134a30d6d81807e91 100644 |
| --- a/chrome/common/extensions/docs/templates/articles/app_codelab3_mvc.html |
| +++ b/chrome/common/extensions/docs/templates/articles/app_codelab3_mvc.html |
| @@ -9,7 +9,7 @@ is the Model-View-Controller (MVC) and its variants, |
| like Model-View-Presentation (MVP).</p> |
| <p>There are several frameworks to help apply |
| -<a href="app_frameworks.html">MVC concepts</a> |
| +<a href="app_frameworks">MVC concepts</a> |
| to a Javascript application, and most of them, |
| as long as they are CSP compliant, can be used in a Chrome App. |
| In this lab, |
| @@ -37,8 +37,8 @@ you will need to add a very simple controller with basic MVC functionalities: |
| <h3 id="update-view">Update view</h3> |
| -<p>Change the <a href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab3_mvc/angularjs/simpleview/index.html">AngularJS index.html</a> or |
| -<a href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab3_mvc/javascript/simpleview/index.html">JavaScript index.html</a> to use a simple sample: |
| +<p>Change the <a href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab3_mvc/angularjs/simpleview/index">AngularJS index</a> or |
|
mkearney1
2014/04/09 19:43:29
Need to make sure links work to GitHub samples wit
mkearney1
2014/04/09 19:43:29
Keep .html here as it refers to a filename for a s
|
| +<a href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab3_mvc/javascript/simpleview/index">JavaScript index</a> to use a simple sample: |
|
mkearney1
2014/04/09 19:43:29
Need to make sure links work to GitHub samples wit
mkearney1
2014/04/09 19:43:29
Keep .html here as it refers to a filename for a s
|
| </p> |
| <tabs data-group="source"> |
| @@ -47,7 +47,7 @@ you will need to add a very simple controller with basic MVC functionalities: |
| <header tabindex="0" data-value="js">JavaScript</header> |
| <content> |
| - <pre data-filename="index.html"> |
| + <pre data-filename="index"> |
|
mkearney1
2014/04/09 19:43:29
Keep .html here as it refers to a filename for a s
|
| <!doctype html> |
| <html ng-app ng-csp> |
| <head> |
| @@ -70,7 +70,7 @@ you will need to add a very simple controller with basic MVC functionalities: |
| </pre> |
| </content> |
| <content> |
| - <pre data-filename="index.html"> |
| + <pre data-filename="index"> |
|
mkearney1
2014/04/09 19:43:29
Keep .html here as it refers to a filename for a s
|
| <!doctype html> |
| <html> |
| <head> |
| @@ -319,8 +319,8 @@ window.addEventListener('DOMContentLoaded', function() { |
| <h3 id="index">Update view</h3> |
| -<p>Change the <a href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab3_mvc/angularjs/withcontroller/index.html">AngularJS index.html</a> or |
| -<a href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab3_mvc/javascript/withcontroller/index.html">JavaScript index.html</a>: |
| +<p>Change the <a href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab3_mvc/angularjs/withcontroller/index">AngularJS index</a> or |
|
mkearney1
2014/04/09 19:43:29
Test that link works without .html to Github repo
mkearney1
2014/04/09 19:43:29
Keep .html here as it refers to a filename in a sa
|
| +<a href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab3_mvc/javascript/withcontroller/index">JavaScript index</a>: |
|
mkearney1
2014/04/09 19:43:29
Again, test link works without .html to Github rep
mkearney1
2014/04/09 19:43:29
Keep .html here as it refers to a filename in a sa
|
| </p> |
| <tabs data-group="source"> |
| @@ -329,7 +329,7 @@ window.addEventListener('DOMContentLoaded', function() { |
| <header tabindex="0" data-value="js">JavaScript</header> |
| <content> |
| - <pre data-filename="index.html"> |
| + <pre data-filename="index"> |
|
mkearney1
2014/04/09 19:43:29
Keep .html here as it refers to a filename in a sa
|
| <html ng-app ng-csp> |
| <head> |
| <script src="angular.min.js"></script> |
| @@ -358,7 +358,7 @@ window.addEventListener('DOMContentLoaded', function() { |
| </pre> |
| </content> |
| <content> |
| - <pre data-filename="index.html"> |
| + <pre data-filename="index"> |
|
mkearney1
2014/04/09 19:43:29
Keep .html here as it refers to a filename in a sa
|
| <!doctype html> |
| <html> |
| <head> |
| @@ -405,7 +405,7 @@ Check the results by reloading the app: open the app, right-click and select Rel |
| <ul> |
| <li><p>Chrome Apps are |
| -<a href="offline_apps.html">offline first</a>, |
| +<a href="offline_apps">offline first</a>, |
| so the recommended way to include third-party scripts is to download |
| and package them inside your app.</p></li> |
| <li><p>You can use any framework you want, |
| @@ -418,11 +418,11 @@ Use them, specially if you want to build a non-trivial application.</p></li> |
| <h2 id="you_should_also_read">You should also read</h2> |
| <ul> |
| -<li><p><a href="angular_framework.html">Build Apps with AngularJS</a> tutorial</p></li> |
| +<li><p><a href="angular_framework">Build Apps with AngularJS</a> tutorial</p></li> |
| <li><p><a href="http://angularjs.org/">AngularJS Todo</a> tutorial</p></li> |
| </ul> |
| <h2 id="what_39_s_next_">What's next?</h2> |
| -<p>In <a href="app_codelab5_data.html">4 - Save and Fetch Data</a>, |
| +<p>In <a href="app_codelab5_data">4 - Save and Fetch Data</a>, |
| you will modify your Todo list app so that Todo items are saved.</p> |
