Chromium Code Reviews Chromium Code Reviews
Issue 219213007:
Remove .html extension from links (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: chrome/common/extensions/docs/templates/articles/app_codelab2_basic.html |
| diff --git a/chrome/common/extensions/docs/templates/articles/app_codelab2_basic.html b/chrome/common/extensions/docs/templates/articles/app_codelab2_basic.html |
| index b8820bb5ebb309bea19743af52a683ce2b087dd0..aca9cecb5d87c6aad291c74fc1343f3a8404f122 100644 |
| --- a/chrome/common/extensions/docs/templates/articles/app_codelab2_basic.html |
| +++ b/chrome/common/extensions/docs/templates/articles/app_codelab2_basic.html |
| @@ -46,7 +46,7 @@ create the background script: <a href="https://github.com/GoogleChrome/chrome-ap |
| <pre data-filename="main.js"> |
| chrome.app.runtime.onLaunched.addListener(function() { |
| - chrome.app.window.create('index.html', { |
| + chrome.app.window.create('index', { |
| bounds: { |
| width: 500, |
| height: 309 |
| @@ -57,9 +57,9 @@ chrome.app.runtime.onLaunched.addListener(function() { |
| <h2 id="view">Create view</h2> |
| -<p>Create the user interface: <a href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab2_basic/index.html">index.html</a> |
| +<p>Create the user interface: <a href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab2_basic/index">index</a> |
|
mkearney1
2014/04/09 19:43:29
Does it matter that this is a GitHub repo? I'm try
|
| -<pre data-filename="index.html"> |
| +<pre data-filename="index"> |
|
mkearney1
2014/04/09 19:43:29
Keep .html here, as it separates this from .js fil
|
| <html> |
| <head> |
| <meta charset="utf-8"> |
| @@ -94,11 +94,11 @@ go to <code>chrome://extensions</code> and click on Inspect Views...</p> |
| <ol> |
| <li><p>Change the text "Hello world" |
| -to "My first app" in index.html.</p></li> |
| +to "My first app" in index.</p></li> |
|
mkearney1
2014/04/09 19:43:29
Keep .html here, as it's a file reference in sampl
|
| <li><p>Change the |
| <a href="https://github.com/GoogleChrome/chrome-app-codelab/blob/master/lab2_basic/main.js">main.js</a> background script to create two windows instead of one. |
| Don't bother to create another html. |
| -For now, you can open index.html on both.</p></li> |
| +For now, you can open index on both.</p></li> |
|
mkearney1
2014/04/09 19:43:29
Keep .html here as it's a file reference in sample
|
| <li><p>After changing code, |
| right-click on your app and select Reload App to reload the changed files. |
| All Developer Tools windows will be reopened when you reload your app.</p></li> |
| @@ -124,14 +124,14 @@ a Reload App option has been added when you run in Developer mode.</li> |
| <h2 id="you_should_also_read">You should also read</h2> |
| <ul> |
| -<li><a href="first_app.html">Create Your First App</a> tutorial</li> |
| -<li><a href="app.runtime.html">chrome.app.runtime</a> reference</li> |
| -<li><a href="app.window.html">chrome.app.window</a> reference</li> |
| +<li><a href="first_app">Create Your First App</a> tutorial</li> |
| +<li><a href="app.runtime">chrome.app.runtime</a> reference</li> |
| +<li><a href="app.window">chrome.app.window</a> reference</li> |
| </ul> |
| <h2 id="what_39_s_next_">What's next?</h2> |
| -<p>In <a href="app_codelab3_mvc.html">3 - Create MVC</a>, |
| +<p>In <a href="app_codelab3_mvc">3 - Create MVC</a>, |
| you will use either pure JavaScript or |
| <a href="http://angularjs.org/">AngluarJS</a> |
| to build your app's model, view, and controller.</p> |
