Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2192023002: arc: Support custom notification size change (Closed)

Created:
4 years, 4 months ago by xiyuan
Modified:
4 years, 4 months ago
Reviewers:
yoshiki, reveman, sky
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, mlamouri+watch-notifications_chromium.org, Peter Beverloo, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@arc-notification-size
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: Support custom notification size change BUG=632455 BUG=b/30477159 TEST=Manual. Run Orbot and observe the notification change its size. Committed: https://crrev.com/cb1c37150e121db2219060eaede70389dc11edea Cr-Commit-Position: refs/heads/master@{#408987}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -10 lines) Patch
M ui/arc/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/arc/arc.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/arc/notification/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ui/arc/notification/arc_custom_notification_view.h View 4 chunks +9 lines, -0 lines 0 comments Download
M ui/arc/notification/arc_custom_notification_view.cc View 4 chunks +26 lines, -9 lines 0 comments Download
M ui/message_center/views/message_center_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (8 generated)
xiyuan
4 years, 4 months ago (2016-07-28 23:06:07 UTC) #2
reveman
lgtm
4 years, 4 months ago (2016-07-28 23:58:37 UTC) #6
yoshiki
lgtm
4 years, 4 months ago (2016-07-29 05:13:34 UTC) #7
xiyuan
sky@, could I get a stamp from you for adding ui/aura as "ui/arc"'s deps? Thanks. ...
4 years, 4 months ago (2016-07-29 13:29:05 UTC) #9
sky
LGTM
4 years, 4 months ago (2016-08-01 16:04:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2192023002/1
4 years, 4 months ago (2016-08-01 16:07:40 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-01 17:04:59 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 17:10:11 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb1c37150e121db2219060eaede70389dc11edea
Cr-Commit-Position: refs/heads/master@{#408987}

Powered by Google App Engine
This is Rietveld 408576698