Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 2187363002: arc: Scale notification surface to fit (Closed)

Created:
4 years, 4 months ago by xiyuan
Modified:
4 years, 4 months ago
Reviewers:
yoshiki, reveman
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: Scale notification surface to fit BUG=632720 BUG=b/30374625 TEST=Manual. Increase resolution and custom notification should always fill chrome notification space. Committed: https://crrev.com/589b2256f24ac204c3fdc17a333aebeac3eb7c07 Cr-Commit-Position: refs/heads/master@{#408630}

Patch Set 1 #

Patch Set 2 : fix typo #

Patch Set 3 : fix floating close button pos on 2560x1700 by using coordinate before scaling #

Total comments: 2

Patch Set 4 : minor clean up #

Patch Set 5 : for nit in #3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -3 lines) Patch
M ui/arc/notification/arc_custom_notification_view.cc View 1 2 3 4 2 chunks +26 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (12 generated)
xiyuan
4 years, 4 months ago (2016-07-28 17:20:40 UTC) #2
reveman
lgtm https://codereview.chromium.org/2187363002/diff/40001/ui/arc/notification/arc_custom_notification_view.cc File ui/arc/notification/arc_custom_notification_view.cc (right): https://codereview.chromium.org/2187363002/diff/40001/ui/arc/notification/arc_custom_notification_view.cc#newcode106 ui/arc/notification/arc_custom_notification_view.cc:106: surface_size != contents_size) { nit: "surface_size != contents_size" ...
4 years, 4 months ago (2016-07-28 18:50:53 UTC) #3
xiyuan
https://codereview.chromium.org/2187363002/diff/40001/ui/arc/notification/arc_custom_notification_view.cc File ui/arc/notification/arc_custom_notification_view.cc (right): https://codereview.chromium.org/2187363002/diff/40001/ui/arc/notification/arc_custom_notification_view.cc#newcode106 ui/arc/notification/arc_custom_notification_view.cc:106: surface_size != contents_size) { On 2016/07/28 18:50:53, reveman wrote: ...
4 years, 4 months ago (2016-07-28 19:32:52 UTC) #5
yoshiki
lgtm
4 years, 4 months ago (2016-07-29 01:25:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2187363002/80001
4 years, 4 months ago (2016-07-29 13:38:14 UTC) #15
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 4 months ago (2016-07-29 13:41:37 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 13:43:58 UTC) #19
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/589b2256f24ac204c3fdc17a333aebeac3eb7c07
Cr-Commit-Position: refs/heads/master@{#408630}

Powered by Google App Engine
This is Rietveld 408576698