[turbofan] Adds speculative opcodes for shift right.

[turbofan] Adds speculative opcodes for shift right.

Drive-by fix: actually match the hint in the IsSpeculativeBinopMatcher.

Committed: https://crrev.com/79ebd37d6590d2cc81d5acfc8296bea2af7c2d30
Cr-Commit-Position: refs/heads/master@{#38176}

[epertoso, 2016-07-28 13:13:22]

Description was changed from

==========
[turbofan] Adds speculative opcodes for shift right.

Drive-by fix: match the hint in the SpeculativeBinopMatcher.
==========

to

==========
[turbofan] Adds speculative opcodes for shift right.

Drive-by fix: actually match the hint in the IsSpeculativeBinopMatcher.
==========

[epertoso, 2016-07-28 13:13:22]

epertoso@chromium.org changed reviewers:
+ bmeurer@chromium.org

[epertoso, 2016-07-28 13:13:31]

The CQ bit was checked by epertoso@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 13:13:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 13:23:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 13:23:28]

Dry run: Try jobs failed on following builders:
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/2...)

[epertoso, 2016-07-28 13:30:52]

The CQ bit was checked by epertoso@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 13:30:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 14:00:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 14:00:14]

Dry run: This issue passed the CQ dry run.

[Benedikt Meurer, 2016-07-28 16:43:02]

https://codereview.chromium.org/2191883002/diff/20001/src/compiler/js-typed-l...
File src/compiler/js-typed-lowering.cc (right):

https://codereview.chromium.org/2191883002/diff/20001/src/compiler/js-typed-l...
src/compiler/js-typed-lowering.cc:593: static const Operator*
SpeculativeVersionOf(
Please make this a member function or even inline it below (as we do for
comparisons).

[epertoso, 2016-07-29 09:35:13]

https://codereview.chromium.org/2191883002/diff/20001/src/compiler/js-typed-l...
File src/compiler/js-typed-lowering.cc (right):

https://codereview.chromium.org/2191883002/diff/20001/src/compiler/js-typed-l...
src/compiler/js-typed-lowering.cc:593: static const Operator*
SpeculativeVersionOf(
On 2016/07/28 16:43:02, Benedikt Meurer wrote:
> Please make this a member function or even inline it below (as we do for
> comparisons).

Done.

[Benedikt Meurer, 2016-07-29 09:35:49]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2016-07-29 09:35:50]

lgtm

[commit-bot: I haz the power, 2016-07-29 09:35:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 09:57:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 09:57:18]

Failed to apply patch for src/compiler/opcodes.h:
While running git apply --index -3 -p1;
  error: patch failed: src/compiler/opcodes.h:204
  Falling back to three-way merge...
  Applied patch to 'src/compiler/opcodes.h' with conflicts.
  U src/compiler/opcodes.h

Patch:       src/compiler/opcodes.h
Index: src/compiler/opcodes.h
diff --git a/src/compiler/opcodes.h b/src/compiler/opcodes.h
index
8d342d5680b0664af8d26867bdb090e221d302fd..3c64b1e77fa03bb8937f2a79d388c0d8a2177255
100644
--- a/src/compiler/opcodes.h
+++ b/src/compiler/opcodes.h
@@ -204,90 +204,92 @@
   V(StringLessThan)                      \
   V(StringLessThanOrEqual)
 
-#define SIMPLIFIED_OTHER_OP_LIST(V)   \
-  V(PlainPrimitiveToNumber)           \
-  V(PlainPrimitiveToWord32)           \
-  V(PlainPrimitiveToFloat64)          \
-  V(BooleanNot)                       \
-  V(SpeculativeNumberAdd)             \
-  V(SpeculativeNumberSubtract)        \
-  V(SpeculativeNumberMultiply)        \
-  V(SpeculativeNumberDivide)          \
-  V(SpeculativeNumberModulus)         \
-  V(SpeculativeNumberEqual)           \
-  V(SpeculativeNumberLessThan)        \
-  V(SpeculativeNumberLessThanOrEqual) \
-  V(NumberAdd)                        \
-  V(NumberSubtract)                   \
-  V(NumberMultiply)                   \
-  V(NumberDivide)                     \
-  V(NumberModulus)                    \
-  V(NumberBitwiseOr)                  \
-  V(NumberBitwiseXor)                 \
-  V(NumberBitwiseAnd)                 \
-  V(NumberShiftLeft)                  \
-  V(SpeculativeNumberShiftLeft)       \
-  V(NumberShiftRight)                 \
-  V(NumberShiftRightLogical)          \
-  V(NumberImul)                       \
-  V(NumberAbs)                        \
-  V(NumberClz32)                      \
-  V(NumberCeil)                       \
-  V(NumberCos)                        \
-  V(NumberCosh)                       \
-  V(NumberFloor)                      \
-  V(NumberFround)                     \
-  V(NumberAcos)                       \
-  V(NumberAcosh)                      \
-  V(NumberAsin)                       \
-  V(NumberAsinh)                      \
-  V(NumberAtan)                       \
-  V(NumberAtanh)                      \
-  V(NumberAtan2)                      \
-  V(NumberExp)                        \
-  V(NumberExpm1)                      \
-  V(NumberLog)                        \
-  V(NumberLog1p)                      \
-  V(NumberLog2)                       \
-  V(NumberLog10)                      \
-  V(NumberMax)                        \
-  V(NumberMin)                        \
-  V(NumberCbrt)                       \
-  V(NumberPow)                        \
-  V(NumberRound)                      \
-  V(NumberSign)                       \
-  V(NumberSin)                        \
-  V(NumberSinh)                       \
-  V(NumberSqrt)                       \
-  V(NumberTan)                        \
-  V(NumberTanh)                       \
-  V(NumberTrunc)                      \
-  V(NumberToInt32)                    \
-  V(NumberToUint32)                   \
-  V(NumberSilenceNaN)                 \
-  V(StringCharCodeAt)                 \
-  V(StringFromCharCode)               \
-  V(CheckBounds)                      \
-  V(CheckIf)                          \
-  V(CheckNumber)                      \
-  V(CheckString)                      \
-  V(CheckTaggedPointer)               \
-  V(CheckTaggedSigned)                \
-  V(CheckFloat64Hole)                 \
-  V(CheckTaggedHole)                  \
-  V(Allocate)                         \
-  V(LoadField)                        \
-  V(LoadBuffer)                       \
-  V(LoadElement)                      \
-  V(StoreField)                       \
-  V(StoreBuffer)                      \
-  V(StoreElement)                     \
-  V(ObjectIsCallable)                 \
-  V(ObjectIsNumber)                   \
-  V(ObjectIsReceiver)                 \
-  V(ObjectIsSmi)                      \
-  V(ObjectIsString)                   \
-  V(ObjectIsUndetectable)             \
+#define SIMPLIFIED_OTHER_OP_LIST(V)     \
+  V(PlainPrimitiveToNumber)             \
+  V(PlainPrimitiveToWord32)             \
+  V(PlainPrimitiveToFloat64)            \
+  V(BooleanNot)                         \
+  V(SpeculativeNumberAdd)               \
+  V(SpeculativeNumberSubtract)          \
+  V(SpeculativeNumberMultiply)          \
+  V(SpeculativeNumberDivide)            \
+  V(SpeculativeNumberModulus)           \
+  V(SpeculativeNumberEqual)             \
+  V(SpeculativeNumberLessThan)          \
+  V(SpeculativeNumberLessThanOrEqual)   \
+  V(NumberAdd)                          \
+  V(NumberSubtract)                     \
+  V(NumberMultiply)                     \
+  V(NumberDivide)                       \
+  V(NumberModulus)                      \
+  V(NumberBitwiseOr)                    \
+  V(NumberBitwiseXor)                   \
+  V(NumberBitwiseAnd)                   \
+  V(NumberShiftLeft)                    \
+  V(SpeculativeNumberShiftLeft)         \
+  V(SpeculativeNumberShiftRight)        \
+  V(SpeculativeNumberShiftRightLogical) \
+  V(NumberShiftRight)                   \
+  V(NumberShiftRightLogical)            \
+  V(NumberImul)                         \
+  V(NumberAbs)                          \
+  V(NumberClz32)                        \
+  V(NumberCeil)                         \
+  V(NumberCos)                          \
+  V(NumberCosh)                         \
+  V(NumberFloor)                        \
+  V(NumberFround)                       \
+  V(NumberAcos)                         \
+  V(NumberAcosh)                        \
+  V(NumberAsin)                         \
+  V(NumberAsinh)                        \
+  V(NumberAtan)                         \
+  V(NumberAtanh)                        \
+  V(NumberAtan2)                        \
+  V(NumberExp)                          \
+  V(NumberExpm1)                        \
+  V(NumberLog)                          \
+  V(NumberLog1p)                        \
+  V(NumberLog2)                         \
+  V(NumberLog10)                        \
+  V(NumberMax)                          \
+  V(NumberMin)                          \
+  V(NumberCbrt)                         \
+  V(NumberPow)                          \
+  V(NumberRound)                        \
+  V(NumberSign)                         \
+  V(NumberSin)                          \
+  V(NumberSinh)                         \
+  V(NumberSqrt)                         \
+  V(NumberTan)                          \
+  V(NumberTanh)                         \
+  V(NumberTrunc)                        \
+  V(NumberToInt32)                      \
+  V(NumberToUint32)                     \
+  V(NumberSilenceNaN)                   \
+  V(StringCharCodeAt)                   \
+  V(StringFromCharCode)                 \
+  V(CheckBounds)                        \
+  V(CheckIf)                            \
+  V(CheckNumber)                        \
+  V(CheckString)                        \
+  V(CheckTaggedPointer)                 \
+  V(CheckTaggedSigned)                  \
+  V(CheckFloat64Hole)                   \
+  V(CheckTaggedHole)                    \
+  V(Allocate)                           \
+  V(LoadField)                          \
+  V(LoadBuffer)                         \
+  V(LoadElement)                        \
+  V(StoreField)                         \
+  V(StoreBuffer)                        \
+  V(StoreElement)                       \
+  V(ObjectIsCallable)                   \
+  V(ObjectIsNumber)                     \
+  V(ObjectIsReceiver)                   \
+  V(ObjectIsSmi)                        \
+  V(ObjectIsString)                     \
+  V(ObjectIsUndetectable)               \
   V(TransitionElementsKind)
 
 #define SIMPLIFIED_OP_LIST(V)      \

[epertoso, 2016-07-29 10:29:26]

The CQ bit was checked by epertoso@chromium.org

[epertoso, 2016-07-29 10:29:26]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2191883002/#ps60001
(title: "Solved merge conflicts")

[commit-bot: I haz the power, 2016-07-29 10:29:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 10:31:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 10:31:39]

Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/9961)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/9945)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/9906)

[epertoso, 2016-07-29 10:36:56]

The CQ bit was checked by epertoso@chromium.org

[epertoso, 2016-07-29 10:36:57]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2191883002/#ps80001
(title: "Really fix the merge conflicts.")

[commit-bot: I haz the power, 2016-07-29 10:37:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 11:04:01]

Description was changed from

==========
[turbofan] Adds speculative opcodes for shift right.

Drive-by fix: actually match the hint in the IsSpeculativeBinopMatcher.
==========

to

==========
[turbofan] Adds speculative opcodes for shift right.

Drive-by fix: actually match the hint in the IsSpeculativeBinopMatcher.
==========

[commit-bot: I haz the power, 2016-07-29 11:04:02]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-29 11:04:28]

Description was changed from

==========
[turbofan] Adds speculative opcodes for shift right.

Drive-by fix: actually match the hint in the IsSpeculativeBinopMatcher.
==========

to

==========
[turbofan] Adds speculative opcodes for shift right.

Drive-by fix: actually match the hint in the IsSpeculativeBinopMatcher.

Committed: https://crrev.com/79ebd37d6590d2cc81d5acfc8296bea2af7c2d30
Cr-Commit-Position: refs/heads/master@{#38176}
==========

[commit-bot: I haz the power, 2016-07-29 11:04:30]

Patchset 5 (id:??) landed as
https://crrev.com/79ebd37d6590d2cc81d5acfc8296bea2af7c2d30
Cr-Commit-Position: refs/heads/master@{#38176}