Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: src/compiler/verifier.cc

Issue 2191883002: [turbofan] Adds speculative opcodes for shift right. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Really fix the merge conflicts. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/typer.cc ('k') | test/mjsunit/compiler/turbo-number-feedback.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/verifier.h" 5 #include "src/compiler/verifier.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <sstream> 10 #include <sstream>
(...skipping 703 matching lines...) Expand 10 before | Expand all | Expand 10 after
714 CheckUpperIs(node, Type::Signed32()); 714 CheckUpperIs(node, Type::Signed32());
715 break; 715 break;
716 case IrOpcode::kNumberShiftLeft: 716 case IrOpcode::kNumberShiftLeft:
717 case IrOpcode::kNumberShiftRight: 717 case IrOpcode::kNumberShiftRight:
718 // (Signed32, Unsigned32) -> Signed32 718 // (Signed32, Unsigned32) -> Signed32
719 CheckValueInputIs(node, 0, Type::Signed32()); 719 CheckValueInputIs(node, 0, Type::Signed32());
720 CheckValueInputIs(node, 1, Type::Unsigned32()); 720 CheckValueInputIs(node, 1, Type::Unsigned32());
721 CheckUpperIs(node, Type::Signed32()); 721 CheckUpperIs(node, Type::Signed32());
722 break; 722 break;
723 case IrOpcode::kSpeculativeNumberShiftLeft: 723 case IrOpcode::kSpeculativeNumberShiftLeft:
724 case IrOpcode::kSpeculativeNumberShiftRight:
724 CheckUpperIs(node, Type::Signed32()); 725 CheckUpperIs(node, Type::Signed32());
725 break; 726 break;
726 case IrOpcode::kNumberShiftRightLogical: 727 case IrOpcode::kNumberShiftRightLogical:
727 // (Unsigned32, Unsigned32) -> Unsigned32 728 // (Unsigned32, Unsigned32) -> Unsigned32
728 CheckValueInputIs(node, 0, Type::Unsigned32()); 729 CheckValueInputIs(node, 0, Type::Unsigned32());
729 CheckValueInputIs(node, 1, Type::Unsigned32()); 730 CheckValueInputIs(node, 1, Type::Unsigned32());
730 CheckUpperIs(node, Type::Unsigned32()); 731 CheckUpperIs(node, Type::Unsigned32());
731 break; 732 break;
733 case IrOpcode::kSpeculativeNumberShiftRightLogical:
734 CheckUpperIs(node, Type::Unsigned32());
735 break;
732 case IrOpcode::kNumberImul: 736 case IrOpcode::kNumberImul:
733 // (Unsigned32, Unsigned32) -> Signed32 737 // (Unsigned32, Unsigned32) -> Signed32
734 CheckValueInputIs(node, 0, Type::Unsigned32()); 738 CheckValueInputIs(node, 0, Type::Unsigned32());
735 CheckValueInputIs(node, 1, Type::Unsigned32()); 739 CheckValueInputIs(node, 1, Type::Unsigned32());
736 CheckUpperIs(node, Type::Signed32()); 740 CheckUpperIs(node, Type::Signed32());
737 break; 741 break;
738 case IrOpcode::kNumberClz32: 742 case IrOpcode::kNumberClz32:
739 // Unsigned32 -> Unsigned32 743 // Unsigned32 -> Unsigned32
740 CheckValueInputIs(node, 0, Type::Unsigned32()); 744 CheckValueInputIs(node, 0, Type::Unsigned32());
741 CheckUpperIs(node, Type::Unsigned32()); 745 CheckUpperIs(node, Type::Unsigned32());
(...skipping 806 matching lines...) Expand 10 before | Expand all | Expand 10 after
1548 replacement->op()->EffectOutputCount() > 0); 1552 replacement->op()->EffectOutputCount() > 0);
1549 DCHECK(!NodeProperties::IsFrameStateEdge(edge) || 1553 DCHECK(!NodeProperties::IsFrameStateEdge(edge) ||
1550 replacement->opcode() == IrOpcode::kFrameState); 1554 replacement->opcode() == IrOpcode::kFrameState);
1551 } 1555 }
1552 1556
1553 #endif // DEBUG 1557 #endif // DEBUG
1554 1558
1555 } // namespace compiler 1559 } // namespace compiler
1556 } // namespace internal 1560 } // namespace internal
1557 } // namespace v8 1561 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/typer.cc ('k') | test/mjsunit/compiler/turbo-number-feedback.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698