Deprecate DLOPEN_GNOME_KEYRING flag

Deprecate DLOPEN_GNOME_KEYRING flag

GnomeKeyringLoader will be moved into a separate utility.
This change makes GnomeKeyringLoader simpler to build on and easier
to move.

Currently, GnomeKeyringLoader compiles different code, depending on
whether keyring is statically linked. Now it will only do dynamic
loading. The only place that requires static linking is tests, and they
don't need GnomeKeyringLoader to do it for them.

BUG=602624
Committed: https://crrev.com/da4e6a834587d15f7696c5a396099fafa719ddf1
Cr-Commit-Position: refs/heads/master@{#408924}

[cfroussios, 2016-07-28 12:39:25]

The CQ bit was checked by cfroussios@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 12:39:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cfroussios, 2016-07-28 12:51:51]

Description was changed from

==========
Deprecate DLOPEN_GNOME_KEYRING flag

Currently, GnomeKeyringLoader compiles different code, depending on
whether keyring is statically linked. Now it will only do dynamic
loading. The only place that requires static linking is tests, and they
don't need GnomeKeyringLoader to do it for them.

This way, GnomeKeyringLoader becomes simpler to move or depend on.


BUG=602624
==========

to

==========
Deprecate DLOPEN_GNOME_KEYRING flag

This makes GnomeKeyringLoader simpler to depend on and easier to move.

Currently, GnomeKeyringLoader compiles different code, depending on
whether keyring is statically linked. Now it will only do dynamic
loading. The only place that requires static linking is tests, and they
don't need GnomeKeyringLoader to do it for them.


BUG=602624
==========

[cfroussios, 2016-07-28 12:52:59]

Description was changed from

==========
Deprecate DLOPEN_GNOME_KEYRING flag

This makes GnomeKeyringLoader simpler to depend on and easier to move.

Currently, GnomeKeyringLoader compiles different code, depending on
whether keyring is statically linked. Now it will only do dynamic
loading. The only place that requires static linking is tests, and they
don't need GnomeKeyringLoader to do it for them.


BUG=602624
==========

to

==========
Deprecate DLOPEN_GNOME_KEYRING flag

GnomeKeyringLoader will be moved into a separate utility.
This change makes GnomeKeyringLoader simpler to depend on and easier 
to move.

Currently, GnomeKeyringLoader compiles different code, depending on
whether keyring is statically linked. Now it will only do dynamic
loading. The only place that requires static linking is tests, and they
don't need GnomeKeyringLoader to do it for them.


BUG=602624
==========

[cfroussios, 2016-07-28 12:57:03]

Description was changed from

==========
Deprecate DLOPEN_GNOME_KEYRING flag

GnomeKeyringLoader will be moved into a separate utility.
This change makes GnomeKeyringLoader simpler to depend on and easier 
to move.

Currently, GnomeKeyringLoader compiles different code, depending on
whether keyring is statically linked. Now it will only do dynamic
loading. The only place that requires static linking is tests, and they
don't need GnomeKeyringLoader to do it for them.


BUG=602624
==========

to

==========
Deprecate DLOPEN_GNOME_KEYRING flag

GnomeKeyringLoader will be moved into a separate utility.
This change makes GnomeKeyringLoader simpler to build on and easier 
to move.

Currently, GnomeKeyringLoader compiles different code, depending on
whether keyring is statically linked. Now it will only do dynamic
loading. The only place that requires static linking is tests, and they
don't need GnomeKeyringLoader to do it for them.


BUG=602624
==========

[cfroussios, 2016-07-28 12:57:40]

cfroussios@chromium.org changed reviewers:
+ vasilii@chromium.org

[cfroussios, 2016-07-28 12:57:41]

Hi. Can you review this change? Thanks!

[commit-bot: I haz the power, 2016-07-28 13:32:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 13:32:27]

Dry run: This issue passed the CQ dry run.

[vasilii, 2016-07-28 13:33:23]

https://codereview.chromium.org/2191873002/diff/1/build/linux/system.gyp
File build/linux/system.gyp (left):

https://codereview.chromium.org/2191873002/diff/1/build/linux/system.gyp#oldc...
build/linux/system.gyp:1038: ['linux_link_gnome_keyring==0', {
Do you want to drop linux_link_gnome_keyring too?

https://codereview.chromium.org/2191873002/diff/1/chrome/browser/password_man...
File chrome/browser/password_manager/native_backend_gnome_x_unittest.cc (right):

https://codereview.chromium.org/2191873002/diff/1/chrome/browser/password_man...
chrome/browser/password_manager/native_backend_gnome_x_unittest.cc:289: #undef
GNOME_KEYRING_ASSIGN_POINTER
It looks complex. If you find a way to get rid of this code style (in a
follow-up CL) it will be great.

[cfroussios, 2016-07-28 15:52:35]

The CQ bit was checked by cfroussios@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 15:52:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cfroussios, 2016-07-28 16:06:39]

https://codereview.chromium.org/2191873002/diff/1/build/linux/system.gyp
File build/linux/system.gyp (left):

https://codereview.chromium.org/2191873002/diff/1/build/linux/system.gyp#oldc...
build/linux/system.gyp:1038: ['linux_link_gnome_keyring==0', {
On 2016/07/28 13:33:22, vasilii wrote:
> Do you want to drop linux_link_gnome_keyring too?

Done.

I didn't want to dive too deep into gyp, because it's been broken all day. I
don't think it's used at all for linux anymore, but we're not deprecating gyp in
this cl.

https://codereview.chromium.org/2191873002/diff/1/chrome/browser/password_man...
File chrome/browser/password_manager/native_backend_gnome_x_unittest.cc (right):

https://codereview.chromium.org/2191873002/diff/1/chrome/browser/password_man...
chrome/browser/password_manager/native_backend_gnome_x_unittest.cc:289: #undef
GNOME_KEYRING_ASSIGN_POINTER
On 2016/07/28 13:33:22, vasilii wrote:
> It looks complex. If you find a way to get rid of this code style (in a
> follow-up CL) it will be great.

Acknowledged.

[vasilii, 2016-07-28 16:42:38]

lgtm

[cfroussios, 2016-07-28 16:52:35]

cfroussios@chromium.org changed reviewers:
+ dpranke@chromium.org, sky@chromium.org

[cfroussios, 2016-07-28 16:52:36]

sky@chromium.org: Please review changes in 
chrome/browser/BUILD.gn

dpranke@chromium.org: Please review changes in 
build/common.gypi
build/linux/system.gyp

Thanks!

[commit-bot: I haz the power, 2016-07-28 18:28:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 18:28:41]

Dry run: This issue passed the CQ dry run.

[cfroussios, 2016-07-29 08:22:34]

cfroussios@chromium.org changed reviewers:
- sky@chromium.org

[cfroussios, 2016-07-29 08:29:24]

cfroussios@chromium.org changed reviewers:
+ thestig@chromium.org

[cfroussios, 2016-07-29 08:29:25]

Changed reviewer for chrome/browser/BUILD.gn, because sky@'s schedule looks
full.

thestig@chromium.org: Please review changes in 
chrome/browser/BUILD.gn

Thanks!

[Lei Zhang, 2016-07-29 09:08:47]

lgtm

[Dirk Pranke, 2016-07-30 00:00:46]

lgtm

[cfroussios, 2016-08-01 06:47:42]

The CQ bit was checked by cfroussios@chromium.org

[commit-bot: I haz the power, 2016-08-01 06:47:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 07:37:24]

Description was changed from

==========
Deprecate DLOPEN_GNOME_KEYRING flag

GnomeKeyringLoader will be moved into a separate utility.
This change makes GnomeKeyringLoader simpler to build on and easier 
to move.

Currently, GnomeKeyringLoader compiles different code, depending on
whether keyring is statically linked. Now it will only do dynamic
loading. The only place that requires static linking is tests, and they
don't need GnomeKeyringLoader to do it for them.


BUG=602624
==========

to

==========
Deprecate DLOPEN_GNOME_KEYRING flag

GnomeKeyringLoader will be moved into a separate utility.
This change makes GnomeKeyringLoader simpler to build on and easier 
to move.

Currently, GnomeKeyringLoader compiles different code, depending on
whether keyring is statically linked. Now it will only do dynamic
loading. The only place that requires static linking is tests, and they
don't need GnomeKeyringLoader to do it for them.


BUG=602624
==========

[commit-bot: I haz the power, 2016-08-01 07:37:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-01 07:38:52]

Description was changed from

==========
Deprecate DLOPEN_GNOME_KEYRING flag

GnomeKeyringLoader will be moved into a separate utility.
This change makes GnomeKeyringLoader simpler to build on and easier 
to move.

Currently, GnomeKeyringLoader compiles different code, depending on
whether keyring is statically linked. Now it will only do dynamic
loading. The only place that requires static linking is tests, and they
don't need GnomeKeyringLoader to do it for them.


BUG=602624
==========

to

==========
Deprecate DLOPEN_GNOME_KEYRING flag

GnomeKeyringLoader will be moved into a separate utility.
This change makes GnomeKeyringLoader simpler to build on and easier
to move.

Currently, GnomeKeyringLoader compiles different code, depending on
whether keyring is statically linked. Now it will only do dynamic
loading. The only place that requires static linking is tests, and they
don't need GnomeKeyringLoader to do it for them.

BUG=602624

Committed: https://crrev.com/da4e6a834587d15f7696c5a396099fafa719ddf1
Cr-Commit-Position: refs/heads/master@{#408924}
==========

[commit-bot: I haz the power, 2016-08-01 07:38:54]

Patchset 2 (id:??) landed as
https://crrev.com/da4e6a834587d15f7696c5a396099fafa719ddf1
Cr-Commit-Position: refs/heads/master@{#408924}