Deprecate DLOPEN_GNOME_KEYRING flag

build/linux/system.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     # If any of the linux_link_FOO below are set to 1, then the corresponding
     # target will be linked against the FOO library (either dynamically or
     # statically, depending on the pkg-config files), as opposed to loading the
     # FOO library dynamically with dlopen.
@@ skipping 969 matching lines @@
       'type': 'none',
       'conditions': [
         ['use_gnome_keyring==1', {
           'direct_dependent_settings': {
             'cflags': [
               '<!@(<(pkg-config) --cflags gnome-keyring-1)',
             ],
             'defines': [
               'USE_GNOME_KEYRING',
             ],
-            'conditions': [
-              ['linux_link_gnome_keyring==0', {
-                'defines': ['DLOPEN_GNOME_KEYRING'],
-              }],
-            ],
           },
           'conditions': [
             ['linux_link_gnome_keyring!=0', {
               'link_settings': {
                 'ldflags': [
                   '<!@(<(pkg-config) --libs-only-L --libs-only-other gnome-keyring-1)',
                 ],
                 'libraries': [
                   '<!@(<(pkg-config) --libs-only-l gnome-keyring-1)',
                 ],
@@ skipping 22 matching lines @@
       'type': 'none',
       'conditions': [
         ['use_gnome_keyring==1', {
           'direct_dependent_settings': {
             'cflags': [
               '<!@(<(pkg-config) --cflags gnome-keyring-1)',
             ],
             'defines': [
               'USE_GNOME_KEYRING',
             ],
-            'conditions': [
-              ['linux_link_gnome_keyring==0', {

[vasilii, 2016/07/28 13:33:22]

Do you want to drop linux_link_gnome_keyring too?

[cfroussios, 2016/07/28 16:06:39]

Done.

I didn't want to dive too deep into gyp, because it's been broken all day. I
don't think it's used at all for linux anymore, but we're not deprecating gyp in
this cl.

-                'defines': ['DLOPEN_GNOME_KEYRING'],
-              }],
-            ],
           },
           'link_settings': {
             'ldflags': [
               '<!@(<(pkg-config) --libs-only-L --libs-only-other gnome-keyring-1)',
             ],
             'libraries': [
               '<!@(<(pkg-config) --libs-only-l gnome-keyring-1)',
             ],
           },
         }],
@@ skipping 241 matching lines @@
             ],
             'libraries': [
               '<!@(<(pkg-config) --libs-only-l libffi)',
             ],
           },
         }],
       ],
     },
   ],
 }