Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Issue 2191733004: [Offline Pages] Configure for no retries (Closed)

Created:
4 years, 4 months ago by Pete Williamson
Modified:
4 years, 4 months ago
Reviewers:
dougarnett
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the concept of retrying a request. To make our life simpler for shipping M54, set the max number of retries to 1. We may turn it back up in a future milestone. BUG=610521 Committed: https://crrev.com/8a57cd40185372b3257bf66434d9d845a04edf89 Cr-Commit-Position: refs/heads/master@{#408680}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M components/offline_pages/background/offliner_policy.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/offline_pages/background/request_coordinator.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/offline_pages/background/request_picker.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Pete Williamson
4 years, 4 months ago (2016-07-28 20:18:00 UTC) #2
dougarnett
Change is lgtm but recommend updating the description though before landing as this is more ...
4 years, 4 months ago (2016-07-29 16:14:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2191733004/1
4 years, 4 months ago (2016-07-29 16:58:37 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 17:35:59 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 17:39:06 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a57cd40185372b3257bf66434d9d845a04edf89
Cr-Commit-Position: refs/heads/master@{#408680}

Powered by Google App Engine
This is Rietveld 408576698