components/offline_pages/background/request_picker.cc - Issue 2191733004: [Offline Pages] Configure for no retries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/background/request_picker.cc

Issue 2191733004: [Offline Pages] Configure for no retries (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/offline_pages/background/request_picker.cc

diff --git a/components/offline_pages/background/request_picker.cc b/components/offline_pages/background/request_picker.cc

index c6ac59ebb38d5d2a8c1f4c029567cb260bd5aef3..d6014069e8cdf746b07abe4a5dbf34ae97839563 100644

--- a/components/offline_pages/background/request_picker.cc

+++ b/components/offline_pages/background/request_picker.cc

@@ -111,7 +111,7 @@ bool RequestPicker::RequestConditionsSatisfied(const SavePageRequest& request) {

// eligible to try again.

// TODO(petewil): Instead, we should have code to remove the page from the

// queue after the last retry.

- if (request.attempt_count() >= policy_->GetMaxRetries())

+ if (request.attempt_count() > policy_->GetMaxTries())

return false;

// If the request is expired, do not consider it.

« no previous file with comments | « components/offline_pages/background/request_coordinator.cc ('k') | no next file » | no next file with comments »