Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2191683003: [css-flexbox] align-content should apply even when there's just a single line (Closed)

Created:
4 years, 4 months ago by cbiesinger
Modified:
4 years, 4 months ago
Reviewers:
dgrogan, eae
CC:
chromium-reviews, cbiesinger, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-flexbox] align-content should apply even when there's just a single line In Jan 2015 the spec changed in https://drafts.csswg.org/css-flexbox/#change-201409-align-content-wrapping Change our code accordingly. This effectively reverts commit 764735dc12285a09a32b7d5ad3a8d6f178b0ab83 BUG=599828 R=eae@chromium.org,dgrogan@chromium.org Committed: https://crrev.com/955a53c8bc7f04b4830acabf7291c603314e0a53 Cr-Commit-Position: refs/heads/master@{#408456}

Patch Set 1 #

Patch Set 2 : Mark Firefox tests as failing; they haven't fixed this bug yet #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -31 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/flexbox/alignContent-applies-with-flexWrap-wrap-with-single-line.html View 2 chunks +23 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/flexbox/flexbox-wordwrap.html View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/flexbox/multiline-align-content.html View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 3 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
cbiesinger
4 years, 4 months ago (2016-07-27 22:58:55 UTC) #1
eae
LGTM
4 years, 4 months ago (2016-07-27 23:01:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2191683003/1
4 years, 4 months ago (2016-07-27 23:04:41 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/267676)
4 years, 4 months ago (2016-07-28 00:40:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2191683003/20001
4 years, 4 months ago (2016-07-28 18:09:31 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-28 19:40:15 UTC) #15
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/955a53c8bc7f04b4830acabf7291c603314e0a53 Cr-Commit-Position: refs/heads/master@{#408456}
4 years, 4 months ago (2016-07-28 19:43:40 UTC) #17
cbiesinger
4 years, 3 months ago (2016-08-29 21:44:37 UTC) #18
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2289793003/ by cbiesinger@chromium.org.

The reason for reverting is: Caused multiple regressions (bug 634672, bug
641789) and I'd like more time to investigate them before shipping this to
users..

Powered by Google App Engine
This is Rietveld 408576698