Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1480)

Unified Diff: third_party/WebKit/LayoutTests/css3/flexbox/alignContent-applies-with-flexWrap-wrap-with-single-line.html

Issue 2191683003: [css-flexbox] align-content should apply even when there's just a single line (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Mark Firefox tests as failing; they haven't fixed this bug yet Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/css3/flexbox/alignContent-applies-with-flexWrap-wrap-with-single-line.html
diff --git a/third_party/WebKit/LayoutTests/css3/flexbox/alignContent-applies-with-flexWrap-wrap-with-single-line.html b/third_party/WebKit/LayoutTests/css3/flexbox/alignContent-applies-with-flexWrap-wrap-with-single-line.html
index 50b5273a19b1902ff67bfcf28568aed4bc0500b9..106b93dace17dc3a0b55441b0b7d669014728607 100644
--- a/third_party/WebKit/LayoutTests/css3/flexbox/alignContent-applies-with-flexWrap-wrap-with-single-line.html
+++ b/third_party/WebKit/LayoutTests/css3/flexbox/alignContent-applies-with-flexWrap-wrap-with-single-line.html
@@ -6,20 +6,28 @@
display: flex;
flex-wrap: wrap;
position: relative;
- height: 75px;
+ height: 70px;
border: 1px solid red;
margin: 5px;
}
+.default > div {
+ height: 20px;
+}
+
.verticalWriting {
display: flex;
flex-wrap: wrap;
position: relative;
- width: 75px;
+ width: 70px;
border: 1px solid red;
margin: 5px;
writing-mode: vertical-lr;
}
+
+.verticalWriting > div {
+ width: 20px;
+}
</style>
<script src="../../resources/testharness.js"></script>
<script src="../../resources/testharnessreport.js"></script>
@@ -27,42 +35,42 @@
</head>
<body onload="checkLayout('.default, .verticalWriting'); ">
<div id=log></div>
-<p>Test for BUG=324178: Chrome incorrectly honors "align-content" in "flex-wrap: wrap" flex containers that only have a single line</p>
+<p>Test that we honor align-content even in single-line flex containers</p>
<div class="default" style="align-content: flex-start">
-<div data-offset-y="0">This text should be at the top of it's container</div>
+<div data-offset-y="0">This text should be at the top of its container</div>
</div>
<div class="default" style="align-content: flex-end">
-<div data-offset-y="0">This text should be at the top of it's container</div>
+<div data-offset-y="50">This text should be at the bottom of its container</div>
</div>
<div class="default" style="align-content: center">
-<div data-offset-y="0">This text should be at the top of it's container</div>
+<div data-offset-y="25">This text should be centered in its container</div>
</div>
<div class="default" style="align-content: space-between">
-<div data-offset-y="0">This text should be at the top of it's container</div>
+<div data-offset-y="0">This text should be at the top of its container</div>
</div>
<div class="default" style="align-content: space-around">
-<div data-offset-y="0">This text should be at the top of it's container</div>
+<div data-offset-y="25">This text should be centered in its container</div>
</div>
<div class="default" style="align-content: stretch">
-<div data-offset-y="0">This text should be at the top of it's container</div>
+<div data-offset-y="0">This text should be at the top of its container</div>
</div>
<div class="verticalWriting" style="align-content: flex-start">
-<div data-offset-x="0">This text should be at the left of it's container</div>
+<div data-offset-x="0">This text should be at the left of its container</div>
</div>
<div class="verticalWriting" style="align-content: flex-end">
-<div data-offset-x="0">This text should be at the left of it's container</div>
+<div data-offset-x="50">This text should be at the right of its container</div>
</div>
<div class="verticalWriting" style="align-content: center">
-<div data-offset-x="0">This text should be at the left of it's container</div>
+<div data-offset-x="25">This text should be centered in its container</div>
</div>
<div class="verticalWriting" style="align-content: space-between">
-<div data-offset-x="0">This text should be at the left of it's container</div>
+<div data-offset-x="0">This text should be at the left of its container</div>
</div>
<div class="verticalWriting" style="align-content: space-around">
-<div data-offset-x="0">This text should be at the left of it's container</div>
+<div data-offset-x="25">This text should be centered in its container</div>
</div>
<div class="verticalWriting" style="align-content: stretch">
-<div data-offset-x="0">This text should be at the left of it's container</div>
+<div data-offset-x="0">This text should be at the left of its container</div>
</div>
</body>
</html>
« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/LayoutTests/css3/flexbox/flexbox-wordwrap.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698