Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 2191633002: Re-land "Remove non-immediate core page load metrics" (Closed)

Created:
4 years, 4 months ago by Bryan McQuade
Modified:
4 years, 4 months ago
CC:
asvitkine+watch_chromium.org, chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-land "Remove non-immediate core page load metrics" This reverts commit 6ea2c7581324e29bf1106af332e3124a17562dbd. When this patch was originally landed in https://codereview.chromium.org/2156093002, it caused some page load metrics browser tests to fail. Those issues have since been addressed in https://codereview.chromium.org/2176803002, so we're ready to land this change again. BUG=630549 Committed: https://crrev.com/bdb7c3816e4a396f6f680bfb33c9a496179c471b Cr-Commit-Position: refs/heads/master@{#408316}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -313 lines) Patch
M chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc View 15 chunks +82 lines, -272 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc View 7 chunks +10 lines, -38 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Bryan McQuade
PTAL. You originally reviewed this change in https://codereview.chromium.org/2156093002. It was reverted, but the issue causing ...
4 years, 4 months ago (2016-07-27 19:51:23 UTC) #5
Ilya Sherman
LGTM (if there's nothing new to review, it's probably fine to just TBR)
4 years, 4 months ago (2016-07-28 00:18:25 UTC) #8
shivanisha
On 2016/07/28 at 00:18:25, isherman wrote: > LGTM (if there's nothing new to review, it's ...
4 years, 4 months ago (2016-07-28 01:38:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2191633002/1
4 years, 4 months ago (2016-07-28 02:31:37 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 02:35:37 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 02:37:01 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bdb7c3816e4a396f6f680bfb33c9a496179c471b
Cr-Commit-Position: refs/heads/master@{#408316}

Powered by Google App Engine
This is Rietveld 408576698