Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 219163005: Move dispatchUnloadEvent to WebFrame, part 1/3. (Closed)

Created:
6 years, 8 months ago by Avi (use Gerrit)
Modified:
6 years, 8 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Move dispatchUnloadEvent to WebFrame, part 1/3. BUG=357782 TEST=no change Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170492

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M Source/web/WebFrameImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebFrameImpl.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 1 chunk +5 lines, -1 line 0 comments Download
M Source/web/tests/WebViewTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M public/web/WebFrame.h View 1 chunk +3 lines, -0 lines 0 comments Download
M public/web/WebView.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Avi (use Gerrit)
6 years, 8 months ago (2014-03-31 16:46:09 UTC) #1
Avi (use Gerrit)
Whoever gets to it first; it's simple.
6 years, 8 months ago (2014-03-31 18:45:21 UTC) #2
abarth-chromium
lgtm
6 years, 8 months ago (2014-03-31 21:15:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/219163005/20001
6 years, 8 months ago (2014-03-31 21:15:30 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 00:07:49 UTC) #5
Message was sent while issue was closed.
Change committed as 170492

Powered by Google App Engine
This is Rietveld 408576698