Source/web/WebViewImpl.cpp - Issue 219163005: Move dispatchUnloadEvent to WebFrame, part 1/3.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebViewImpl.cpp

Issue 219163005: Move dispatchUnloadEvent to WebFrame, part 1/3. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebViewImpl.cpp

diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp

index d8dba48c527ac8ec15612711b359f1ccbd023485..11df1f3f62de0004d6636c61b418a41a7b9ad9e9 100644

--- a/Source/web/WebViewImpl.cpp

+++ b/Source/web/WebViewImpl.cpp

@@ -2403,8 +2403,12 @@ void WebViewImpl::setPageEncoding(const WebString& encodingName)

void WebViewImpl::dispatchUnloadEvent()

{

+ WebFrame* frame = mainFrame();

+ if (!frame)

+ return;

// Run unload handlers.

- m_page->mainFrame()->loader().closeURL();

+ frame->dispatchUnloadEvent();

}

WebFrame* WebViewImpl::mainFrame()

« no previous file with comments | « Source/web/WebFrameImpl.cpp ('k') | Source/web/tests/WebViewTest.cpp » ('j') | no next file with comments »