Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 21916002: Fix crashing bugs when dart code executed inside the debugger triggers breakpoints (Closed)

Created:
7 years, 4 months ago by Jacob
Modified:
7 years, 4 months ago
Reviewers:
vsm
CC:
reviews+dom_dartlang.org
Visibility:
Public.

Description

Cleanup scope auto entry-exit code to reduce boilerplate slightly. Disable all cases where the debugger could trigger a breakpoint while already in the debugger to avoid Dartium crashers on triggering the debugger while already in the debugger. BUG= R=vsm@google.com Committed: https://src.chromium.org/viewvc/multivm?view=rev&revision=1324

Patch Set 1 : Ready to review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -116 lines) Patch
M LayoutTests/dart/inspector/evaluate-in-console.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dart/inspector/evaluate-in-console-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/dart/DartDebugServer.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/bindings/dart/DartHandleProxy.cpp View 25 chunks +109 lines, -110 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jacob
Modify DartHandleProxy so that invoking Dart code from within a proxy never triggers the debugger. ...
7 years, 4 months ago (2013-08-02 16:52:59 UTC) #1
vsm
lgtm
7 years, 4 months ago (2013-08-02 19:56:47 UTC) #2
Jacob
7 years, 4 months ago (2013-08-02 20:07:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r1324 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698