Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: Source/bindings/dart/DartDebugServer.cpp

Issue 21916002: Fix crashing bugs when dart code executed inside the debugger triggers breakpoints (Closed) Base URL: svn://svn.chromium.org/multivm/trunk/webkit
Patch Set: Ready to review Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/dart/DartDebugServer.cpp
diff --git a/Source/bindings/dart/DartDebugServer.cpp b/Source/bindings/dart/DartDebugServer.cpp
index f2705fae27278ae2cbbaa3d2645926a99193a2bc..82ab3e1e04bb1998aa48d0b6b1a399801091a62d 100644
--- a/Source/bindings/dart/DartDebugServer.cpp
+++ b/Source/bindings/dart/DartDebugServer.cpp
@@ -438,13 +438,7 @@ static v8::Handle<v8::Value> evaluateInScope(const v8::Arguments& args)
v8::Debug::GetDebugContext()->Enter();
v8::Handle<v8::Function> function = script->Run().As<v8::Function>();
v8::Debug::GetDebugContext()->Exit();
- Dart_ExceptionPauseInfo previousPauseInfo = Dart_GetExceptionPauseInfo();
- // FIXME: it is not clear this is the right long term solution but for now
- // we prevent pausing on exceptions when executing an evaluate statement to
- // avoid crashing debug dartium builds.
- Dart_SetExceptionPauseInfo(kNoPauseOnExceptions);
v8::Handle<v8::Value> ret = function->Call(receiver, 2, scopes);
- Dart_SetExceptionPauseInfo(previousPauseInfo);
return ret;
}
« no previous file with comments | « LayoutTests/dart/inspector/evaluate-in-console-expected.txt ('k') | Source/bindings/dart/DartHandleProxy.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698