third_party/WebKit/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp - Issue 2191533003: Refactor Timer classes in preparation for landing FrameTimers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp

Issue 2191533003: Refactor Timer classes in preparation for landing FrameTimers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Android build fix Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.h ('K') | « third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp ('k') | third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h » ('j') | third_party/WebKit/Source/platform/Timer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp

diff --git a/third_party/WebKit/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp b/third_party/WebKit/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp

index 6d94fe7bfa1f55ba04805d3f315974e08aeee24e..9909a3fe5b0b5311d4817f5988b2fe4f23464299 100644

--- a/third_party/WebKit/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp

+++ b/third_party/WebKit/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp

@@ -29,7 +29,7 @@ public:

private:

SetSinkIdResolver(ScriptState*, HTMLMediaElement&, const String& sinkId);

- void timerFired(Timer<SetSinkIdResolver>*);

+ void timerFired(TimerBase*);

Member<HTMLMediaElement> m_element;

String m_sinkId;

@@ -57,7 +57,7 @@ void SetSinkIdResolver::startAsync()

m_timer.startOneShot(0, BLINK_FROM_HERE);

}

-void SetSinkIdResolver::timerFired(Timer<SetSinkIdResolver>* timer)

+void SetSinkIdResolver::timerFired(TimerBase* timer)

{

ExecutionContext* context = getExecutionContext();

ASSERT(context && context->isDocument());