third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.h - Issue 2191533003: Refactor Timer classes in preparation for landing FrameTimers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.h

Issue 2191533003: Refactor Timer classes in preparation for landing FrameTimers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Android build fix Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/loader/FrameLoader.h ('K') | « third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp ('k') | third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp » ('j') | third_party/WebKit/Source/platform/Timer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.h

diff --git a/third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.h b/third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.h

index 35e6148a087b043a2029483d02eb628947dfd1b0..42835fa37f52f3ddd5a3843410dde6e754278f5b 100644

--- a/third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.h

+++ b/third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.h

@@ -58,11 +58,11 @@ private:

void invalidateRect(const IntRect&) override;

void scheduleAnimation(Widget*) override;

- void setTimer(Timer<SVGImageChromeClient>*);

- void animationTimerFired(Timer<SVGImageChromeClient>*);

+ void setTimer(TaskRunnerTimer<SVGImageChromeClient>*);

+ void animationTimerFired(TimerBase*);

SVGImage* m_image;

- std::unique_ptr<Timer<SVGImageChromeClient>> m_animationTimer;

+ std::unique_ptr<TaskRunnerTimer<SVGImageChromeClient>> m_animationTimer;

haraken 2016/07/28 14:44:46 Yeah, this looks ugly...

enum {

Running,

Suspended,