Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Unified Diff: third_party/WebKit/Source/core/layout/ImageQualityController.h

Issue 2191533003: Refactor Timer classes in preparation for landing FrameTimers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ImageQualityController.h
diff --git a/third_party/WebKit/Source/core/layout/ImageQualityController.h b/third_party/WebKit/Source/core/layout/ImageQualityController.h
index d6636b7d3f9ae9a5600c2aa8e5d317de5e6865a8..3feab63e1a7bda03b65649a165268cf96c8eefdc 100644
--- a/third_party/WebKit/Source/core/layout/ImageQualityController.h
+++ b/third_party/WebKit/Source/core/layout/ImageQualityController.h
@@ -77,14 +77,14 @@ private:
void objectDestroyed(const LayoutObject&);
bool isEmpty() { return m_objectLayerSizeMap.isEmpty(); }
- void highQualityRepaintTimerFired(Timer<ImageQualityController>*);
+ void highQualityRepaintTimerFired(TimerBase*);
void restartTimer(double lastFrameTimeMonotonic);
// Only for use in testing.
- void setTimer(Timer<ImageQualityController>*);
+ void setTimer(TaskRunnerTimer<ImageQualityController>*);
dcheng 2016/07/28 13:09:51 Do we have a better way to mock out timers for tes
haraken 2016/07/28 14:44:46 Yeah, this looks ugly. Can we make MockTimer inher
dcheng 2016/07/29 02:23:18 Hmm, the more I think about, I think that Timer sh
ObjectLayerSizeMap m_objectLayerSizeMap;
- std::unique_ptr<Timer<ImageQualityController>> m_timer;
+ std::unique_ptr<TaskRunnerTimer<ImageQualityController>> m_timer;
double m_frameTimeWhenTimerStarted;
// For calling set().

Powered by Google App Engine
This is Rietveld 408576698