Refactor Timer classes in preparation for landing FrameTimers.

third_party/WebKit/Source/core/layout/ImageQualityController.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 59 matching lines @@
     ImageQualityController();
 
     static bool has(const LayoutObject&);
     void set(const LayoutObject&, LayerSizeMap* innerMap, const void* layer, const LayoutSize&, bool isResizing);
 
     bool shouldPaintAtLowQuality(const LayoutObject&, Image*, const void* layer, const LayoutSize&, double lastFrameTimeMonotonic);
     void removeLayer(const LayoutObject&, LayerSizeMap* innerMap, const void* layer);
     void objectDestroyed(const LayoutObject&);
     bool isEmpty() { return m_objectLayerSizeMap.isEmpty(); }
 
-    void highQualityRepaintTimerFired(Timer<ImageQualityController>*);
+    void highQualityRepaintTimerFired(TimerBase*);
     void restartTimer(double lastFrameTimeMonotonic);
 
     // Only for use in testing.
-    void setTimer(Timer<ImageQualityController>*);
+    void setTimer(TaskRunnerTimer<ImageQualityController>*);

[dcheng, 2016/07/28 13:09:51]

Do we have a better way to mock out timers for tests with the new scheduling
stuff? This is pretty ugly.

[haraken, 2016/07/28 14:44:46]

Yeah, this looks ugly. Can we make MockTimer inherit from TimerBase and make
setTimer take a |TimerBase*| parameter?

[dcheng, 2016/07/29 02:23:18]

Hmm, the more I think about, I think that Timer should just not be templated
(and use WTF::bind() internally to capture the timer task).

I suppose making it a TimerBase won't hurt for now though, so done.

 
     ObjectLayerSizeMap m_objectLayerSizeMap;
-    std::unique_ptr<Timer<ImageQualityController>> m_timer;
+    std::unique_ptr<TaskRunnerTimer<ImageQualityController>> m_timer;
     double m_frameTimeWhenTimerStarted;
 
     // For calling set().
     FRIEND_TEST_ALL_PREFIXES(LayoutPartTest, DestroyUpdatesImageQualityController);
 
     // For calling setTimer(),
     FRIEND_TEST_ALL_PREFIXES(ImageQualityControllerTest, LowQualityFilterForResizingImage);
     FRIEND_TEST_ALL_PREFIXES(ImageQualityControllerTest, MediumQualityFilterForNotAnimatedWhileAnotherAnimates);
     FRIEND_TEST_ALL_PREFIXES(ImageQualityControllerTest, DontKickTheAnimationTimerWhenPaintingAtTheSameSize);
     FRIEND_TEST_ALL_PREFIXES(ImageQualityControllerTest, DontRestartTimerUnlessAdvanced);
 };
 
 } // namespace blink
 
 #endif