Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: src/messages.h

Issue 2191293002: Move FormatStackTrace to C++ (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Remove unneeded code from messages.js Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/messages.h
diff --git a/src/messages.h b/src/messages.h
index acc42037e53b67389425186aa6daa0815775ce3f..d8a72cfdee7dc42151f6cb8f97479250a4d65891 100644
--- a/src/messages.h
+++ b/src/messages.h
@@ -51,6 +51,8 @@ class CallSite {
Handle<Object> GetFunctionName();
Handle<Object> GetScriptNameOrSourceUrl();
Handle<Object> GetMethodName();
+ Handle<Object> GetTypeName();
+ Handle<Object> GetEvalOrigin();
// Return 1-based line number, including line offset.
int GetLineNumber();
// Return 1-based column number, including column offset if first line.
@@ -94,6 +96,17 @@ MaybeHandle<Object> ConstructError(Isolate* isolate, Handle<JSFunction> target,
Handle<Object> message, FrameSkipMode mode,
bool suppress_detailed_trace);
+MaybeHandle<String> ErrorToString(Isolate* isolate, Handle<Object> recv);
+
+MaybeHandle<Object> ConstructCallSite(Isolate* isolate,
Yang 2016/08/01 06:49:18 Can we make this a static method of the CallSite c
jgruber 2016/08/01 10:52:56 Moved to all-static ErrorUtils class as discussed.
+ Handle<JSFunction> target,
+ Handle<Object> new_target,
+ Handle<Object> receiver,
+ Handle<Object> fun, Handle<Object> pos,
+ Handle<Object> strict_mode);
+
+MaybeHandle<String> CallSiteToString(Isolate* isolate, Handle<Object> recv);
Yang 2016/08/01 06:49:18 same here.
jgruber 2016/08/01 10:52:56 Ditto.
+
#define MESSAGE_TEMPLATES(T) \
/* Error */ \
T(None, "") \

Powered by Google App Engine
This is Rietveld 408576698