Move FormatStackTrace to C++

src/messages.h

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // The infrastructure used for (localized) message reporting in V8.
 //
 // Note: there's a big unresolved issue about ownership of the data
 // structures used by this framework.
 
 #ifndef V8_MESSAGES_H_
@@ skipping 33 matching lines @@
 
 
 class CallSite {
  public:
   CallSite(Isolate* isolate, Handle<JSObject> call_site_obj);
 
   Handle<Object> GetFileName();
   Handle<Object> GetFunctionName();
   Handle<Object> GetScriptNameOrSourceUrl();
   Handle<Object> GetMethodName();
+  Handle<Object> GetTypeName();
+  Handle<Object> GetEvalOrigin();
   // Return 1-based line number, including line offset.
   int GetLineNumber();
   // Return 1-based column number, including column offset if first line.
   int GetColumnNumber();
   bool IsNative();
   bool IsToplevel();
   bool IsEval();
   bool IsConstructor();
 
   bool IsJavaScript() { return !fun_.is_null(); }
@@ skipping 23 matching lines @@
   // Skip all frames until a specified caller function is seen.
   SKIP_UNTIL_SEEN,
   SKIP_NONE,
 };
 
 MaybeHandle<Object> ConstructError(Isolate* isolate, Handle<JSFunction> target,
                                    Handle<Object> new_target,
                                    Handle<Object> message, FrameSkipMode mode,
                                    bool suppress_detailed_trace);
 
+MaybeHandle<String> ErrorToString(Isolate* isolate, Handle<Object> recv);
+
+MaybeHandle<Object> ConstructCallSite(Isolate* isolate,

[Yang, 2016/08/01 06:49:18]

Can we make this a static method of the CallSite class?

[jgruber, 2016/08/01 10:52:56]

Moved to all-static ErrorUtils class as discussed.

+                                      Handle<JSFunction> target,
+                                      Handle<Object> new_target,
+                                      Handle<Object> receiver,
+                                      Handle<Object> fun, Handle<Object> pos,
+                                      Handle<Object> strict_mode);
+
+MaybeHandle<String> CallSiteToString(Isolate* isolate, Handle<Object> recv);

[Yang, 2016/08/01 06:49:18]

same here.

[jgruber, 2016/08/01 10:52:56]

Ditto.

+
 #define MESSAGE_TEMPLATES(T)                                                   \
   /* Error */                                                                  \
   T(None, "")                                                                  \
   T(CyclicProto, "Cyclic __proto__ value")                                     \
   T(Debugger, "Debugger: %")                                                   \
   T(DebuggerLoading, "Error loading debugger")                                 \
   T(DefaultOptionsMissing, "Internal % error. Default options are missing.")   \
   T(UncaughtException, "Uncaught %")                                           \
   T(Unsupported, "Not supported")                                              \
   T(WrongServiceType, "Internal error, wrong service type: %")                 \
@@ skipping 451 matching lines @@
   static Handle<String> GetMessage(Isolate* isolate, Handle<Object> data);
   static std::unique_ptr<char[]> GetLocalizedMessage(Isolate* isolate,
                                                      Handle<Object> data);
 };
 
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_MESSAGES_H_