[DevTools] Fix text representation of IP addresses in SAN certificates

[DevTools] Fix text representation of IP addresses in SAN certificates

BUG=632555
Committed: https://crrev.com/b758e1cbb05284d39cd59a9f5140574318ad7898
Cr-Commit-Position: refs/heads/master@{#409105}

[ddchen, 2016-07-29 03:50:06]

Description was changed from

==========
[DevTools] Fix text representation of IP addresses in SAN certificates

BUG=632555
==========

to

==========
[DevTools] Fix text representation of IP addresses in SAN certificates

BUG=632555
==========

[ddchen, 2016-07-29 03:50:06]

ddchen@chromium.org changed reviewers:
+ dgozman@chromium.org, yurys@chromium.org

[ddchen, 2016-07-29 03:50:35]

The CQ bit was checked by ddchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 03:50:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 04:31:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 04:31:57]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-08-01 23:28:04]

lgtm

https://codereview.chromium.org/2191243002/diff/1/content/browser/devtools/pr...
File content/browser/devtools/protocol/network_handler.cc (right):

https://codereview.chromium.org/2191243002/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/network_handler.cc:322: net::IPAddress
ip_addr(reinterpret_cast<const unsigned char*>(ip.c_str()),
Let's be consistent with net::IPAddress and use "const uint8_t*" ?

[ddchen, 2016-08-01 23:34:40]

The CQ bit was checked by ddchen@chromium.org

[ddchen, 2016-08-01 23:34:40]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2191243002/#ps20001
(title: "Change cast type")

[commit-bot: I haz the power, 2016-08-01 23:35:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 00:41:25]

Description was changed from

==========
[DevTools] Fix text representation of IP addresses in SAN certificates

BUG=632555
==========

to

==========
[DevTools] Fix text representation of IP addresses in SAN certificates

BUG=632555
==========

[commit-bot: I haz the power, 2016-08-02 00:41:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-02 00:44:29]

Description was changed from

==========
[DevTools] Fix text representation of IP addresses in SAN certificates

BUG=632555
==========

to

==========
[DevTools] Fix text representation of IP addresses in SAN certificates

BUG=632555

Committed: https://crrev.com/b758e1cbb05284d39cd59a9f5140574318ad7898
Cr-Commit-Position: refs/heads/master@{#409105}
==========

[commit-bot: I haz the power, 2016-08-02 00:44:30]

Patchset 2 (id:??) landed as
https://crrev.com/b758e1cbb05284d39cd59a9f5140574318ad7898
Cr-Commit-Position: refs/heads/master@{#409105}