[DevTools] Fix text representation of IP addresses in SAN certificates

content/browser/devtools/protocol/network_handler.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/devtools/protocol/network_handler.h"
 
 #include <stddef.h>
 
 #include "base/containers/hash_tables.h"
 #include "base/strings/stringprintf.h"
@@ skipping 298 matching lines @@
 
   std::string name(cert->subject().GetDisplayName());
   std::string issuer(cert->issuer().GetDisplayName());
   base::Time valid_from = cert->valid_start();
   base::Time valid_to = cert->valid_expiry();
 
   std::vector<std::string> dns_names;
   std::vector<std::string> ip_addrs;
   cert->GetSubjectAltName(&dns_names, &ip_addrs);
 
+  // IP addresses are in raw network bytes and must be converted to string form
+  std::vector<std::string> ip_addrs_string;
+  for (const std::string& ip : ip_addrs) {
+    net::IPAddress ip_addr(reinterpret_cast<const uint8_t*>(ip.c_str()),
+                           ip.length());
+    ip_addrs_string.push_back(ip_addr.ToString());
+  }
+
   *result = CertificateDetails::Create()
-                    ->set_subject(CertificateSubject::Create()
+                ->set_subject(CertificateSubject::Create()
                                   ->set_name(name)
                                   ->set_san_dns_names(dns_names)
-                                  ->set_san_ip_addresses(ip_addrs))
-                    ->set_issuer(issuer)
-                    ->set_valid_from(valid_from.ToDoubleT())
-                    ->set_valid_to(valid_to.ToDoubleT());
+                                  ->set_san_ip_addresses(ip_addrs_string))
+                ->set_issuer(issuer)
+                ->set_valid_from(valid_from.ToDoubleT())
+                ->set_valid_to(valid_to.ToDoubleT());
   return Response::OK();
 }
 
 Response NetworkHandler::ShowCertificateViewer(int certificate_id) {
   if (!host_)
     return Response::InternalError("Could not connect to view");
   WebContents* web_contents = WebContents::FromRenderFrameHost(host_);
   web_contents->GetDelegate()->ShowCertificateViewerInDevTools(
       web_contents, certificate_id);
   return Response::OK();
 }
 
 }  // namespace network
 }  // namespace devtools
 }  // namespace content