Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: third_party/WebKit/Source/platform/geometry/FloatRect.h

Issue 2191233002: Add platform/geometry pretty printers for logging and testing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adjust tests to work around uninteresting cross-platform differences Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/geometry/FloatRect.h
diff --git a/third_party/WebKit/Source/platform/geometry/FloatRect.h b/third_party/WebKit/Source/platform/geometry/FloatRect.h
index 07c32cbff3dbec4a4def7583ad3992af71ed71e7..74132e43b021be86bce8f1f6c63016ee42fec1eb 100644
--- a/third_party/WebKit/Source/platform/geometry/FloatRect.h
+++ b/third_party/WebKit/Source/platform/geometry/FloatRect.h
@@ -189,15 +189,9 @@ public:
operator gfx::RectF() const;
#if ENABLE(ASSERT)
- // Prints the rect to the screen.
- void show() const;
bool mayNotHaveExactIntRectRepresentation() const;
#endif
-#ifndef NDEBUG
- String toString() const;
-#endif
-
private:
FloatPoint m_location;
FloatSize m_size;
@@ -261,9 +255,7 @@ PLATFORM_EXPORT IntRect roundedIntRect(const FloatRect&);
// Map supplied rect from srcRect to an equivalent rect in destRect.
PLATFORM_EXPORT FloatRect mapRect(const FloatRect&, const FloatRect& srcRect, const FloatRect& destRect);
-// Redeclared here to avoid ODR issues.
-// See platform/testing/GeometryPrinters.h.
-void PrintTo(const FloatRect&, std::ostream*);
+PLATFORM_EXPORT std::ostream& operator<<(std::ostream&, const FloatRect&);
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698