Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Unified Diff: third_party/WebKit/Source/platform/geometry/FloatRect.cpp

Issue 2191233002: Add platform/geometry pretty printers for logging and testing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adjust tests to work around uninteresting cross-platform differences Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/geometry/FloatRect.cpp
diff --git a/third_party/WebKit/Source/platform/geometry/FloatRect.cpp b/third_party/WebKit/Source/platform/geometry/FloatRect.cpp
index 5210919a235dd774e0e93011a0d94b07802dceea..c5f4755885fd42c988cd7a73617914b9dd0672b1 100644
--- a/third_party/WebKit/Source/platform/geometry/FloatRect.cpp
+++ b/third_party/WebKit/Source/platform/geometry/FloatRect.cpp
@@ -32,7 +32,7 @@
#include "third_party/skia/include/core/SkRect.h"
#include "ui/gfx/geometry/rect_f.h"
#include "wtf/MathExtras.h"
-#include "wtf/text/WTFString.h"
+#include <ostream> // NOLINT
namespace blink {
@@ -197,17 +197,6 @@ FloatRect unionRect(const Vector<FloatRect>& rects)
return result;
}
-#ifndef NDEBUG
-void FloatRect::show() const
-{
- LayoutRect(*this).show();
-}
-
-String FloatRect::toString() const
-{
- return String::format("%s %s", location().toString().ascii().data(), size().toString().ascii().data());
-}
-#endif
IntRect enclosingIntRect(const FloatRect& rect)
{
@@ -244,4 +233,14 @@ FloatRect mapRect(const FloatRect& r, const FloatRect& srcRect, const FloatRect&
r.width() * widthScale, r.height() * heightScale);
}
+std::ostream& operator<<(std::ostream& os, const FloatRect& rect)
+{
+ os << "FloatRect("
+ << "x=" << rect.x() << ", "
+ << "y=" << rect.y() << ", "
+ << "width=" << rect.width() << ", "
+ << "height=" << rect.height() << ")";
+ return os;
+}
+
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698