Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(944)

Unified Diff: third_party/WebKit/Source/platform/geometry/FloatQuad.cpp

Issue 2191233002: Add platform/geometry pretty printers for logging and testing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fewer redundant spaces, more toString tests Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/geometry/FloatQuad.cpp
diff --git a/third_party/WebKit/Source/platform/geometry/FloatQuad.cpp b/third_party/WebKit/Source/platform/geometry/FloatQuad.cpp
index 3759aa67fff91a2a20e4af7ba4418b90c2a92f63..dfb085f799155eb44ee7508e8d7ab012c943044e 100644
--- a/third_party/WebKit/Source/platform/geometry/FloatQuad.cpp
+++ b/third_party/WebKit/Source/platform/geometry/FloatQuad.cpp
@@ -31,14 +31,11 @@
#include "platform/geometry/FloatQuad.h"
#include "third_party/skia/include/core/SkPoint.h"
+#include "wtf/text/WTFString.h"
#include <algorithm>
#include <cmath>
#include <limits>
-#ifndef NDEBUG
-#include <stdio.h>
-#endif
-
namespace blink {
static inline float min4(float a, float b, float c, float d)
@@ -252,11 +249,13 @@ bool FloatQuad::isCounterclockwise() const
return determinant(m_p2 - m_p1, m_p3 - m_p2) < 0;
}
-#ifndef NDEBUG
-void FloatQuad::show() const
+String FloatQuad::toString() const
{
- fprintf(stderr, "FloatQuad: [p1=(%f,%f), p2=(%f,%f), p3=(%f,%f), p4=(%f,%f))]\n", m_p1.x(), m_p1.y(), m_p2.x(), m_p2.y(), m_p3.x(), m_p3.y(), m_p4.x(), m_p4.y());
+ return String::format("%s; %s; %s; %s",
+ m_p1.toString().ascii().data(),
+ m_p2.toString().ascii().data(),
+ m_p3.toString().ascii().data(),
+ m_p4.toString().ascii().data());
}
-#endif
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/platform/geometry/FloatQuad.h ('k') | third_party/WebKit/Source/platform/geometry/FloatQuadTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698