[MD settings] remove label float from dropdowns so that they center correctly

[MD settings] remove label float from dropdowns so that they center correctly

This CL adds the no-label-float property to dropdowns without a label so
that they center correctly vertically.

BUG=632543
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/8f17545cbfb8920106632a5e7d35ae57c0df4296
Cr-Commit-Position: refs/heads/master@{#408696}

[dschuyler, 2016-07-29 01:20:12]

Description was changed from

==========
[MD settings] remove label float from dropdowns so that they center correctly

This CL adds the no-label-float property to dropdowns without a label so
that they center correctly vertically.

BUG=632543
==========

to

==========
[MD settings] remove label float from dropdowns so that they center correctly

This CL adds the no-label-float property to dropdowns without a label so
that they center correctly vertically.

BUG=632543
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2016-07-29 01:20:15]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 01:20:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-07-29 01:23:54]

dschuyler@chromium.org changed reviewers:
+ stevenjb@chromium.org

[dschuyler, 2016-07-29 01:23:55]

screen shots at: http://imgur.com/a/JfQYC

[commit-bot: I haz the power, 2016-07-29 02:32:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 02:32:11]

Dry run: This issue passed the CQ dry run.

[stevenjb, 2016-07-29 16:21:08]

stevenjb@chromium.org changed reviewers:
+ michaelpg@chromium.org

[stevenjb, 2016-07-29 16:21:08]

https://codereview.chromium.org/2191203002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/search_page/search_page.html (right):

https://codereview.chromium.org/2191203002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/search_page/search_page.html:22:
<paper-dropdown-menu vertical-align="auto" no-label-float>
I am wondering if we could do something like this in the shared CSS so that we
do not need to add this everywhere (values copied from
paper-dropdown-menu-light.html):

paper-dropdown-menu {
  --paper-dropdown-menu-input {
    padding-top: 0;
  }
  --paper-dropdown-menu-label {
    top: 8px;
  }
  --paper-dropdown-menu-icon {
    margin-top: 0px;
  }
}

The disadvantage is that we would have to maintain that styling. Also, there are
a couple of CSS rules that do not have associated CSS vars; I don't think they
will matter, but they might?

+michaelpg@, WDYT?

[michaelpg, 2016-07-29 17:40:36]

https://codereview.chromium.org/2191203002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/search_page/search_page.html (right):

https://codereview.chromium.org/2191203002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/search_page/search_page.html:22:
<paper-dropdown-menu vertical-align="auto" no-label-float>
On 2016/07/29 16:21:08, stevenjb wrote:
> I am wondering if we could do something like this in the shared CSS so that we
> do not need to add this everywhere (values copied from
> paper-dropdown-menu-light.html):
> 
> paper-dropdown-menu {
>   --paper-dropdown-menu-input {
>     padding-top: 0;
>   }
>   --paper-dropdown-menu-label {
>     top: 8px;
>   }
>   --paper-dropdown-menu-icon {
>     margin-top: 0px;
>   }
> }
> 
> The disadvantage is that we would have to maintain that styling. Also, there
are
> a couple of CSS rules that do not have associated CSS vars; I don't think they
> will matter, but they might?
> 
> +michaelpg@, WDYT?

seems like no-label-float does a variety of magical[1] things including
affecting the ripple[2] and things dependent on state[3][4].

[1]
https://github.com/PolymerElements/paper-dropdown-menu/blob/master/paper-drop...
[2]
https://github.com/PolymerElements/paper-dropdown-menu/blob/master/paper-drop...
[3]
https://github.com/PolymerElements/paper-input/blob/master/paper-input-contai...
[4]
https://github.com/PolymerElements/paper-input/blob/master/paper-input-contai...

so... if we don't use a label, no-label-float seems worthwhile.

[stevenjb, 2016-07-29 17:45:34]

lgtm

https://codereview.chromium.org/2191203002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/search_page/search_page.html (right):

https://codereview.chromium.org/2191203002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/search_page/search_page.html:22:
<paper-dropdown-menu vertical-align="auto" no-label-float>
On 2016/07/29 17:40:36, michaelpg wrote:
> On 2016/07/29 16:21:08, stevenjb wrote:
> > I am wondering if we could do something like this in the shared CSS so that
we
> > do not need to add this everywhere (values copied from
> > paper-dropdown-menu-light.html):
> > 
> > paper-dropdown-menu {
> >   --paper-dropdown-menu-input {
> >     padding-top: 0;
> >   }
> >   --paper-dropdown-menu-label {
> >     top: 8px;
> >   }
> >   --paper-dropdown-menu-icon {
> >     margin-top: 0px;
> >   }
> > }
> > 
> > The disadvantage is that we would have to maintain that styling. Also, there
> are
> > a couple of CSS rules that do not have associated CSS vars; I don't think
they
> > will matter, but they might?
> > 
> > +michaelpg@, WDYT?
> 
> seems like no-label-float does a variety of magical[1] things including
> affecting the ripple[2] and things dependent on state[3][4].
> 
> [1]
>
https://github.com/PolymerElements/paper-dropdown-menu/blob/master/paper-drop...
> [2]
>
https://github.com/PolymerElements/paper-dropdown-menu/blob/master/paper-drop...
> [3]
>
https://github.com/PolymerElements/paper-input/blob/master/paper-input-contai...
> [4]
>
https://github.com/PolymerElements/paper-input/blob/master/paper-input-contai...
> 
> so... if we don't use a label, no-label-float seems worthwhile.

OK. Wish there were a way to change the default. Oh well.

[dschuyler, 2016-07-29 18:29:21]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2016-07-29 18:29:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 18:33:46]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-29 18:35:05]

Description was changed from

==========
[MD settings] remove label float from dropdowns so that they center correctly

This CL adds the no-label-float property to dropdowns without a label so
that they center correctly vertically.

BUG=632543
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] remove label float from dropdowns so that they center correctly

This CL adds the no-label-float property to dropdowns without a label so
that they center correctly vertically.

BUG=632543
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/8f17545cbfb8920106632a5e7d35ae57c0df4296
Cr-Commit-Position: refs/heads/master@{#408696}
==========

[commit-bot: I haz the power, 2016-07-29 18:35:06]

Patchset 1 (id:??) landed as
https://crrev.com/8f17545cbfb8920106632a5e7d35ae57c0df4296
Cr-Commit-Position: refs/heads/master@{#408696}