Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: chrome/browser/resources/settings/search_page/search_page.html

Issue 2191203002: [MD settings] remove label float from dropdowns so that they center correctly (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/site_settings/media_picker.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable.html"> 2 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable.html">
3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> 3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">
4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-dropdown-menu/pap er-dropdown-menu.html"> 4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-dropdown-menu/pap er-dropdown-menu.html">
5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-listbox/paper-lis tbox.html"> 5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-listbox/paper-lis tbox.html">
6 <link rel="import" href="/route.html"> 6 <link rel="import" href="/route.html">
7 <link rel="import" href="/search_engines_page/search_engines_page.html"> 7 <link rel="import" href="/search_engines_page/search_engines_page.html">
8 <link rel="import" href="/search_engines_page/search_engines_browser_proxy.html" > 8 <link rel="import" href="/search_engines_page/search_engines_browser_proxy.html" >
9 <link rel="import" href="/settings_page/settings_animated_pages.html"> 9 <link rel="import" href="/settings_page/settings_animated_pages.html">
10 <link rel="import" href="/settings_page/settings_subpage.html"> 10 <link rel="import" href="/settings_page/settings_subpage.html">
11 <link rel="import" href="/settings_shared_css.html"> 11 <link rel="import" href="/settings_shared_css.html">
12 12
13 <dom-module id="settings-search-page"> 13 <dom-module id="settings-search-page">
14 <template> 14 <template>
15 <style include="settings-shared"> 15 <style include="settings-shared">
16 </style> 16 </style>
17 <settings-animated-pages id="pages" current-route="{{currentRoute}}" 17 <settings-animated-pages id="pages" current-route="{{currentRoute}}"
18 section="search"> 18 section="search">
19 <neon-animatable id="main"> 19 <neon-animatable id="main">
20 <div class="settings-box first"> 20 <div class="settings-box first">
21 <p class="start">$i18n{searchExplanation}</p> 21 <p class="start">$i18n{searchExplanation}</p>
22 <paper-dropdown-menu vertical-align="auto"> 22 <paper-dropdown-menu vertical-align="auto" no-label-float>
stevenjb 2016/07/29 16:21:08 I am wondering if we could do something like this
michaelpg 2016/07/29 17:40:36 seems like no-label-float does a variety of magica
stevenjb 2016/07/29 17:45:34 OK. Wish there were a way to change the default. O
23 <paper-listbox class="dropdown-content" 23 <paper-listbox class="dropdown-content"
24 selected="[[getSelectedSearchEngineIndex_(searchEngines_)]]" 24 selected="[[getSelectedSearchEngineIndex_(searchEngines_)]]"
25 on-iron-select="onIronSelect_"> 25 on-iron-select="onIronSelect_">
26 <template is="dom-repeat" items="[[searchEngines_]]"> 26 <template is="dom-repeat" items="[[searchEngines_]]">
27 <button class="dropdown-item" role="option"> 27 <button class="dropdown-item" role="option">
28 [[item.name]] 28 [[item.name]]
29 </button> 29 </button>
30 </template> 30 </template>
31 </paper-listbox> 31 </paper-listbox>
32 </paper-dropdown-menu> 32 </paper-dropdown-menu>
33 </div> 33 </div>
34 <div class="settings-box"> 34 <div class="settings-box">
35 <paper-button on-tap="onManageSearchEnginesTap_" 35 <paper-button on-tap="onManageSearchEnginesTap_"
36 class="primary-button"> 36 class="primary-button">
37 $i18n{searchEnginesManage} 37 $i18n{searchEnginesManage}
38 </paper-button> 38 </paper-button>
39 </div> 39 </div>
40 </neon-animatable> 40 </neon-animatable>
41 <template is="dom-if" name="search-engines"> 41 <template is="dom-if" name="search-engines">
42 <settings-subpage page-title="$i18n{searchEnginesManage}"> 42 <settings-subpage page-title="$i18n{searchEnginesManage}">
43 <settings-search-engines-page></settings-search-engines-page> 43 <settings-search-engines-page></settings-search-engines-page>
44 </settings-subpage> 44 </settings-subpage>
45 </template> 45 </template>
46 </settings-animated-pages> 46 </settings-animated-pages>
47 </template> 47 </template>
48 <script src="search_page.js"></script> 48 <script src="search_page.js"></script>
49 </dom-module> 49 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/settings/site_settings/media_picker.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698