third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/dom-breakpoints-editing-dom-from-inspector.html - Issue 2191183003: DevTools: extract model from DOMBreakpointsSidebarPane

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/dom-breakpoints-editing-dom-from-inspector.html

Issue 2191183003: DevTools: extract model from DOMBreakpointsSidebarPane (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address CL feedback from PS6 Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/dom-breakpoints.html ('k') | third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/dom-breakpoints-expected.txt » ('j') | third_party/WebKit/Source/devtools/front_end/elements/module.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/dom-breakpoints-editing-dom-from-inspector.html

diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/dom-breakpoints-editing-dom-from-inspector.html b/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/dom-breakpoints-editing-dom-from-inspector.html

index 7c125ece0383d274e846e0c2409187e0eda8f274..6b053e85c11fba94be5355e54f922d0a45a25d72 100644

--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/dom-breakpoints-editing-dom-from-inspector.html

+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/dom-breakpoints-editing-dom-from-inspector.html

@@ -7,8 +7,6 @@

function test()

{

- var pane = WebInspector.domBreakpointsSidebarPane;

InspectorTest.runDebuggerTestSuite([

function testRemoveNode(next)

{

@@ -17,7 +15,7 @@ function test()

function step2(node)

{

- pane._setBreakpoint(node, pane._breakpointTypes.NodeRemoved, true);

+ WebInspector.domBreakpointManager.setBreakpoint(node, WebInspector.DOMBreakpointsSidebarPane.BreakpointTypes.NodeRemoved, true);

InspectorTest.addResult("Set NodeRemoved DOM breakpoint.");

node.removeNode(next);

}

@@ -30,7 +28,7 @@ function test()

function step2(node)

{

- pane._setBreakpoint(node, pane._breakpointTypes.AttributeModified, true);

+ WebInspector.domBreakpointManager.setBreakpoint(node, WebInspector.DOMBreakpointsSidebarPane.BreakpointTypes.AttributeModified, true);

InspectorTest.addResult("Set AttributeModified DOM breakpoint.");

node.setAttribute("title", "a title", next);

}