Add   instead of plain space when it is inserted before the empty text node

Add   instead of plain space when it is inserted before the empty text node

This CL fixes the regression that space key doesn't work in the gmail
chat window.

BUG=632300
TEST=editing/inserting/insert-space.html

Committed: https://crrev.com/4dab74137593abb0888e415294aeb80da27362e3
Cr-Commit-Position: refs/heads/master@{#408571}

[joone, 2016-07-29 00:55:12]

The CQ bit was checked by joone.hur@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 00:55:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joone, 2016-07-29 01:00:34]

joone.hur@intel.com changed reviewers:
+ yosin@chromium.org

[joone, 2016-07-29 01:00:34]

Hi yosin@, please review this CL.

[yosin_UTC9, 2016-07-29 01:15:57]

lgtm

Thanks for quick response!

https://codereview.chromium.org/2191163002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
(right):

https://codereview.chromium.org/2191163002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp:738:
(isEndOfParagraph(visibleDownstreamPos) || (unsigned)downstream ==
text.length())
OPTIONAL: I think using local variable |shouldEmitNBSPbeforeEnd| to describe
third parameter improves readability. If you agree, please introduce, otherwise
it is OK to ignore this comment.

[commit-bot: I haz the power, 2016-07-29 02:08:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 02:08:59]

Dry run: This issue passed the CQ dry run.

[joone, 2016-07-29 03:32:24]

The CQ bit was checked by joone.hur@intel.com

[commit-bot: I haz the power, 2016-07-29 03:32:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 03:36:17]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-29 03:40:23]

Description was changed from

==========
Add   instead of plain space when it is inserted before the empty text node

This CL fixes the regression that space key doesn't work in the gmail
chat window.

BUG=632300
TEST=editing/inserting/insert-space.html
==========

to

==========
Add   instead of plain space when it is inserted before the empty text node

This CL fixes the regression that space key doesn't work in the gmail
chat window.

BUG=632300
TEST=editing/inserting/insert-space.html

Committed: https://crrev.com/4dab74137593abb0888e415294aeb80da27362e3
Cr-Commit-Position: refs/heads/master@{#408571}
==========

[commit-bot: I haz the power, 2016-07-29 03:40:24]

Patchset 1 (id:??) landed as
https://crrev.com/4dab74137593abb0888e415294aeb80da27362e3
Cr-Commit-Position: refs/heads/master@{#408571}

[joone, 2016-07-29 03:50:19]

On 2016/07/29 01:15:57, Yosi_UTC9 wrote:
> lgtm
> 
> Thanks for quick response!
> 
>
https://codereview.chromium.org/2191163002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
> (right):
> 
>
https://codereview.chromium.org/2191163002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp:738:
> (isEndOfParagraph(visibleDownstreamPos) || (unsigned)downstream ==
> text.length())
> OPTIONAL: I think using local variable |shouldEmitNBSPbeforeEnd| to describe
> third parameter improves readability. If you agree, please introduce,
otherwise
> it is OK to ignore this comment.

I will prepare a seperate patch for this. Thanks for the idea.