third_party/WebKit/LayoutTests/editing/inserting/insert-space.html - Issue 2191163002: Add   instead of plain space when it is inserted before the empty text node

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/editing/inserting/insert-space.html

Issue 2191163002: Add   instead of plain space when it is inserted before the empty text node (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp » ('j') | third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype HTML>	1 <!doctype HTML>

2 <script src="../../resources/testharness.js"></script>	2 <script src="../../resources/testharness.js"></script>

3 <script src="../../resources/testharnessreport.js"></script>	3 <script src="../../resources/testharnessreport.js"></script>

4 <script src="../assert_selection.js"></script>	4 <script src="../assert_selection.js"></script>

5 <script>	5 <script>

6 test(() => assert_selection(	6 test(() => assert_selection(

7 '<div contenteditable><p>A\|B</p></div>',	7 '<div contenteditable><p>A\|B</p></div>',

8 'insertText \ ',	8 'insertText \ ',

9 '<div contenteditable><p>A \|B</p></div>'),	9 '<div contenteditable><p>A \|B</p></div>'),

10 'insert a plain space in the middle of text node');	10 'insert a plain space in the middle of text node');

11	11

12 test(() => assert_selection(	12 test(() => assert_selection(

13 '<div contenteditable><p id="para"></p></div>',	13 '<div contenteditable><p id="para"></p></div>',

14 selection => {	14 selection => {

15 var para = selection.document.getElementById('para');	15 var para = selection.document.getElementById('para');

16 para.appendChild(selection.document.createTextNode('A'));	16 para.appendChild(selection.document.createTextNode('A'));

17 para.appendChild(selection.document.createTextNode('B'));	17 para.appendChild(selection.document.createTextNode('B'));

18 selection.collapse(para.firstChild, 1);	18 selection.collapse(para.firstChild, 1);

19	19

20 selection.document.execCommand('insertText', false, ' ');	20 selection.document.execCommand('insertText', false, ' ');

21 },	21 },

22 '<div contenteditable><p id="para">A \|B</p></div>'),	22 '<div contenteditable><p id="para">A \|B</p></div>'),

23 'insert a plain space between two inserted text nodes');	23 'insert a plain space between two inserted text nodes');

	24

	25 test(() => assert_selection(

	26 '<div contenteditable><p id="para"></p></div>',

	27 selection => {

	28 var para = selection.document.getElementById('para');

	29 para.appendChild(selection.document.createTextNode('A'));

	30 para.appendChild(selection.document.createTextNode(''));

	31 selection.collapse(para.firstChild, 1);

	32

	33 selection.document.execCommand('insertText', false, ' ');

	34 },

	35 '<div contenteditable><p id="para">A\u00A0\|</p></div>'),

	36 'Insert a   instead of plain space when it is inserted before the empty t ext node');

24 </script>	37 </script>

OLD	NEW