Issue 21910004: Revert 215101 "Linux: use sandbox binary alongside chrome."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21910004: Revert 215101 "Linux: use sandbox binary alongside chrome." (Closed)

Created:
7 years, 4 months ago by tonyg

Modified:
7 years, 4 months ago

Reviewers:
Paweł Hajdan Jr.

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 215101 "Linux: use sandbox binary alongside chrome." It breaks the page cycler benchmarks. BUG=267640 > Linux: use sandbox binary alongside chrome. > > This removes linux_sandbox_path and instead expects sandbox binary > to be in the same directory as chrome (or CHROME_DEVEL_SANDBOX to be > set). > > This will be helpful for SxS support on Linux, where the sandbox path > would be different depending on channel. > > BUG=38598 > R=avi@chromium.org, jln@chromium.org > > Review URL: https://codereview.chromium.org/20197003 TBR=phajdan.jr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215300

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -34 lines)			Patch
M	trunk/src/build/common.gypi	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	trunk/src/content/browser/browser_main_loop.cc	View	3 chunks	+26 lines, -34 lines	0 comments	Download
M	trunk/src/content/content_browser.gypi	View	1 chunk	+8 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r215300.