Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2190833004: Reland [inspector] add inspector protocol parser test build target. (Closed)

Created:
4 years, 4 months ago by Yang
Modified:
4 years, 4 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland [inspector] add inspector protocol parser test build target. BUG=chromium:580337 Committed: https://crrev.com/b8229434c9fd3bfef81fb77d88779d0e78d06662 Committed: https://crrev.com/3e3ff89d4b0c5699c0bd589e7027f346b583ab5b Cr-Original-Commit-Position: refs/heads/master@{#38135} Cr-Commit-Position: refs/heads/master@{#38190}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : silence one more msvc compile warning #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1279 lines, -5 lines) Patch
M .gitignore View 1 2 3 2 chunks +6 lines, -1 line 0 comments Download
M DEPS View 1 2 3 1 chunk +6 lines, -2 lines 0 comments Download
M gypfiles/all.gyp View 1 chunk +2 lines, -1 line 0 comments Download
M gypfiles/standalone.gypi View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
A src/inspector/BUILD.gn View 1 2 1 chunk +102 lines, -0 lines 0 comments Download
A src/inspector/inspector.gyp View 1 chunk +100 lines, -0 lines 0 comments Download
A src/inspector/js_protocol.json View 1 chunk +990 lines, -0 lines 0 comments Download
M test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A test/inspector_protocol_parser_test/BUILD.gn View 1 chunk +23 lines, -0 lines 0 comments Download
A + test/inspector_protocol_parser_test/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
A test/inspector_protocol_parser_test/RunTests.cpp View 1 chunk +17 lines, -0 lines 0 comments Download
A test/inspector_protocol_parser_test/inspector_protocol_parser_test.gyp View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 35 (21 generated)
Yang
4 years, 4 months ago (2016-07-28 11:42:03 UTC) #3
Michael Achenbach
lgtm if trybot compile passes
4 years, 4 months ago (2016-07-28 12:02:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2190833004/20001
4 years, 4 months ago (2016-07-28 12:35:50 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-28 12:38:37 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/b8229434c9fd3bfef81fb77d88779d0e78d06662 Cr-Commit-Position: refs/heads/master@{#38135}
4 years, 4 months ago (2016-07-28 12:41:43 UTC) #14
Michael Achenbach
Busted the roll again: https://codereview.chromium.org/2187753004/ :(
4 years, 4 months ago (2016-07-29 06:57:14 UTC) #15
Michael Achenbach
If I'm not mistaken, it passed on the "Win" bot this time, but failed "Win ...
4 years, 4 months ago (2016-07-29 06:59:35 UTC) #16
Michael Achenbach
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2193143002/ by machenbach@chromium.org. ...
4 years, 4 months ago (2016-07-29 07:01:43 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2190833004/40001
4 years, 4 months ago (2016-07-29 11:50:59 UTC) #25
Michael Achenbach
lgtm
4 years, 4 months ago (2016-07-29 11:53:10 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/20565)
4 years, 4 months ago (2016-07-29 11:53:12 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2190833004/60001
4 years, 4 months ago (2016-08-01 04:57:14 UTC) #31
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-01 05:42:32 UTC) #33
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 05:42:49 UTC) #35
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3e3ff89d4b0c5699c0bd589e7027f346b583ab5b
Cr-Commit-Position: refs/heads/master@{#38190}

Powered by Google App Engine
This is Rietveld 408576698