build/toolchain/gcc_solink_wrapper.py - Issue 2190813002: Add LC_ALL=C to gcc linker wrappers to speed up links

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/toolchain/gcc_solink_wrapper.py

Issue 2190813002: Add LC_ALL=C to gcc linker wrappers to speed up links (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/toolchain/gcc_solink_wrapper.py

diff --git a/build/toolchain/gcc_solink_wrapper.py b/build/toolchain/gcc_solink_wrapper.py

index 45c489d25bd8e12a886c36235b2f2e639835cd6b..65d4617ce18c3bb9b272ec870b6b434dab0d4c42 100755

--- a/build/toolchain/gcc_solink_wrapper.py

+++ b/build/toolchain/gcc_solink_wrapper.py

@@ -100,6 +100,9 @@ def main():

help='Linking command')

args = parser.parse_args()

+ # Work-around for gold being slow-by-default. http://crbug.com/632230

+ os.environ['LC_ALL'] = 'C'

pasko 2016/07/28 10:03:56 bring it back to the original after linking? I am

agrieve 2016/07/28 14:14:39 Done.

# First, run the actual link.

result = subprocess.call(CommandToRun(args.command))

if result != 0:

« no previous file with comments | « build/toolchain/gcc_link_wrapper.py ('k') | no next file » | no next file with comments »