Add LC_ALL=C to gcc linker wrappers to speed up links

build/toolchain/gcc_solink_wrapper.py

 #!/usr/bin/env python
 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Runs 'ld -shared' and generates a .TOC file that's untouched when unchanged.
 
 This script exists to avoid using complex shell commands in
 gcc_toolchain.gni's tool("solink"), in case the host running the compiler
 does not have a POSIX-like shell (e.g. Windows).
@@ skipping 82 matching lines @@
                       help='Output table-of-contents file',
                       metavar='FILE')
   parser.add_argument('--output',
                       required=True,
                       help='Final output shared object file',
                       metavar='FILE')
   parser.add_argument('command', nargs='+',
                       help='Linking command')
   args = parser.parse_args()
 
+  # Work-around for gold being slow-by-default. http://crbug.com/632230
+  os.environ['LC_ALL'] = 'C'

[pasko, 2016/07/28 10:03:56]

bring it back to the original after linking?

I am not as confident that:
* CollectTOC/UpdateTOC/strip would behave correctly with modified locale
* whatever someone else adds later in the wrapper won't do harm under this
non-default environment

just to be extra safe..

[agrieve, 2016/07/28 14:14:39]

Done.

+
   # First, run the actual link.
   result = subprocess.call(CommandToRun(args.command))
   if result != 0:
     return result
 
   # Next, generate the contents of the TOC file.
   result, toc = CollectTOC(args)
   if result != 0:
     return result
 
   # If there is an existing TOC file with identical contents, leave it alone.
   # Otherwise, write out the TOC file.
   UpdateTOC(args.tocfile, toc)
 
   # Finally, strip the linked shared object file (if desired).
   if args.strip:
     result = subprocess.call(CommandToRun([args.strip, '--strip-unneeded',
                                            '-o', args.output, args.sofile]))
 
   return result
 
 
 if __name__ == "__main__":
   sys.exit(main())