Issue 2190773003: [ABANDONED] Simplify ash shelf dimmer.

Issue 2190773003: [ABANDONED] Simplify ash shelf dimmer. (Closed)

Created:
4 years, 4 months ago by msw

Modified:
4 years, 4 months ago

Reviewers:

CC:
chromium-reviews, kalyank, sadrul

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[ABANDONED; THE SHELF DIMMER WILL BE REMOVED WITH MD, BEFORE MASH SHIPS.] Simplify ash shelf dimmer. Nix dimmer view/widget/image; use the opaque foreground. (0.25f opacity black bar instead of IDR_ASH_SHELF_DIMMING) (see before/after pictures at http://crbug.com/615155#c35) Extract the local 'DimmerEventFilter' -> 'Dimmer' EventHandler. Use for shelf window (not root window) pre-target handling. Add PointerWatcher functionality for external touch presses. TODO: Refine drag/drop behavior (for dragging onto the shelf). Remove unnecessary ShelfWidget dimming test helpers. Remove WmShelf::IsDimmed; use GetBackgroundType instead. Simplify ShelfLayoutManagerTest: - Use CreateTestWidget where possible. - Use AshTestBase::GetEventGenerator() throughout. - Use and cache display::Screen::GetPrimaryDisplay(). - Use GetDimsShelf instead of GetDimmingAlphaForTest. - Remove unnecessary event generator uses. - Try to re-enable some tests. - Try to avoid SupportsHostWindowResize early returns. BUG=615155 TEST=Automated tests; no behavior changes; slight appearance change.

Patch Set 1 #

Patch Set 2 : Refine beahvior; cleanup code; update tests. #

Patch Set 3 : Refine behavior further; huge test cleanup. #

Patch Set 4 : Remove GetDimmingOpacityForTest #

Patch Set 5 : Remove WmShelf::IsDimmed(); use GetBackgroundType() instead. #

Patch Set 6 : Sync and rebase; cleanup #

Patch Set 7 : Restore an EventHandler object; fix behavior tests. #

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+315 lines, -696 lines)			Patch
M	ash/aura/wm_shelf_aura.h	View	1 2 3 4	1 chunk	+0 lines, -1 line	0 comments	Download
M	ash/aura/wm_shelf_aura.cc	View	1 2 3 4	1 chunk	+0 lines, -4 lines	0 comments	Download
M	ash/common/shelf/app_list_button.cc	View	1 2 3 4	1 chunk	+3 lines, -7 lines	0 comments	Download
M	ash/common/shelf/overflow_button.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/common/shelf/wm_shelf.h	View	1 2 3 4	1 chunk	+0 lines, -3 lines	0 comments	Download
M	ash/common/system/tray/tray_background_view.cc	View	1 2 3 4	1 chunk	+1 line, -3 lines	0 comments	Download
M	ash/mus/bridge/wm_shelf_mus.h	View	1 2 3 4	1 chunk	+0 lines, -1 line	0 comments	Download
M	ash/mus/bridge/wm_shelf_mus.cc	View	1 2 3 4	1 chunk	+0 lines, -5 lines	0 comments	Download
M	ash/resources/ash_resources.grd	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
D	ash/resources/default_100_percent/common/shelf/shelf_dimming.png	View	1 2	Binary file		0 comments	Download
D	ash/resources/default_200_percent/common/shelf/shelf_dimming.png	View	1 2	Binary file		0 comments	Download
M	ash/shelf/shelf_layout_manager.cc	View	1 2 3 4 5 6	2 chunks	+3 lines, -4 lines	0 comments	Download
M	ash/shelf/shelf_layout_manager_unittest.cc	View	1 2 3 4 5 6	42 chunks	+146 lines, -314 lines	0 comments	Download
M	ash/shelf/shelf_widget.h	View	1 2 3 4 5 6	1 chunk	+4 lines, -13 lines	0 comments	Download
M	ash/shelf/shelf_widget.cc	View	1 2 3 4 5 6	12 chunks	+133 lines, -330 lines	0 comments	Download
M	ui/views/widget/drop_helper.h	View	1 2 3 4 5 6	1 chunk	+4 lines, -2 lines	0 comments	Download
M	ui/views/widget/drop_helper.cc	View	1 2 3 4 5 6	4 chunks	+12 lines, -7 lines	0 comments	Download
M	ui/views/widget/widget.h	View	1 2 3 4 5 6	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/views/widget/widget.cc	View	1 2 3 4 5 6	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (8 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

msw

Description was changed from ========== Simplify ash shelf dimmer. BUG=557406 ========== to ========== Simplify ash ...

4 years, 4 months ago (2016-07-29 02:10:09 UTC) #2

msw

The CQ bit was checked by msw@chromium.org to run a CQ dry run

4 years, 4 months ago (2016-07-29 02:23:50 UTC) #3

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2190773003/110001

4 years, 4 months ago (2016-07-29 02:24:02 UTC) #4

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 4 months ago (2016-07-29 03:02:20 UTC) #5

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/253020)

4 years, 4 months ago (2016-07-29 03:02:22 UTC) #6

msw

Description was changed from ========== Simplify ash shelf dimmer. Nix dimmer view/widget/handler; use opaque foreground. ...

4 years, 4 months ago (2016-08-01 17:19:33 UTC) #7

Description was changed from

==========
Simplify ash shelf dimmer.

Nix dimmer view/widget/handler; use opaque foreground.
(0.25f opacity black bar instead of IDR_ASH_SHELF_DIMMING)
(see before/after pictures at http://crbug.com/615155#c35)

Update dimming in ShelfWidget::On[Mouse|Touch]Event.
Make ShelfWidget a PointerWatcher for mouse/touch press.

Remove unnecessary ShelfWidget dimming test helpers.
Remove WmShelf::IsDimmed; use GetBackgroundType instead.

Simplify ShelfLayoutManagerTest:
- Use CreateTestWidget where possible.
- Use AshTestBase::GetEventGenerator() throughout.
- Use and cache display::Screen::GetPrimaryDisplay().
- Use GetDimsShelf instead of GetDimmingAlphaForTest.
- Remove unnecessary event generator uses.
- Try to re-enable some tests.
- Try to avoid SupportsHostWindowResize early returns.

BUG=615155
TEST=Automated tests; no behavior changes; slight appearance change.
==========

to

==========
Simplify ash shelf dimmer.

Nix dimmer view/widget/image; use the opaque foreground.
(0.25f opacity black bar instead of IDR_ASH_SHELF_DIMMING)
(see before/after pictures at http://crbug.com/615155#c35)

Extract the local 'DimmerEventFilter' -> 'Dimmer' EventHandler.
Use for shelf window (not root window) pre-target handling.
Add PointerWatcher functionality for external touch presses.
TODO: Refine drag/drop behavior (for dragging onto the shelf).

Remove unnecessary ShelfWidget dimming test helpers.
Remove WmShelf::IsDimmed; use GetBackgroundType instead.

Simplify ShelfLayoutManagerTest:
- Use CreateTestWidget where possible.
- Use AshTestBase::GetEventGenerator() throughout.
- Use and cache display::Screen::GetPrimaryDisplay().
- Use GetDimsShelf instead of GetDimmingAlphaForTest.
- Remove unnecessary event generator uses.
- Try to re-enable some tests.
- Try to avoid SupportsHostWindowResize early returns.

BUG=615155
TEST=Automated tests; no behavior changes; slight appearance change.
==========

msw

4 years, 4 months ago (2016-08-01 18:59:10 UTC) #8

Description was changed from

==========
Simplify ash shelf dimmer.

Nix dimmer view/widget/image; use the opaque foreground.
(0.25f opacity black bar instead of IDR_ASH_SHELF_DIMMING)
(see before/after pictures at http://crbug.com/615155#c35)

Extract the local 'DimmerEventFilter' -> 'Dimmer' EventHandler.
Use for shelf window (not root window) pre-target handling.
Add PointerWatcher functionality for external touch presses.
TODO: Refine drag/drop behavior (for dragging onto the shelf).

Remove unnecessary ShelfWidget dimming test helpers.
Remove WmShelf::IsDimmed; use GetBackgroundType instead.

Simplify ShelfLayoutManagerTest:
- Use CreateTestWidget where possible.
- Use AshTestBase::GetEventGenerator() throughout.
- Use and cache display::Screen::GetPrimaryDisplay().
- Use GetDimsShelf instead of GetDimmingAlphaForTest.
- Remove unnecessary event generator uses.
- Try to re-enable some tests.
- Try to avoid SupportsHostWindowResize early returns.

BUG=615155
TEST=Automated tests; no behavior changes; slight appearance change.
==========

to

==========
[ABANDONED; THE SHELF DIMMER WILL BE REMOVED WITH MD, BEFORE MASH SHIPS.]

Simplify ash shelf dimmer.

Nix dimmer view/widget/image; use the opaque foreground.
(0.25f opacity black bar instead of IDR_ASH_SHELF_DIMMING)
(see before/after pictures at http://crbug.com/615155#c35)

Extract the local 'DimmerEventFilter' -> 'Dimmer' EventHandler.
Use for shelf window (not root window) pre-target handling.
Add PointerWatcher functionality for external touch presses.
TODO: Refine drag/drop behavior (for dragging onto the shelf).

Remove unnecessary ShelfWidget dimming test helpers.
Remove WmShelf::IsDimmed; use GetBackgroundType instead.

Simplify ShelfLayoutManagerTest:
- Use CreateTestWidget where possible.
- Use AshTestBase::GetEventGenerator() throughout.
- Use and cache display::Screen::GetPrimaryDisplay().
- Use GetDimsShelf instead of GetDimmingAlphaForTest.
- Remove unnecessary event generator uses.
- Try to re-enable some tests.
- Try to avoid SupportsHostWindowResize early returns.

BUG=615155
TEST=Automated tests; no behavior changes; slight appearance change.
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages