ash/common/shelf/overflow_button.cc - Issue 2190773003: [ABANDONED] Simplify ash shelf dimmer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/common/shelf/overflow_button.cc

Issue 2190773003: [ABANDONED] Simplify ash shelf dimmer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Restore an EventHandler object; fix behavior tests. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/common/shelf/overflow_button.cc

diff --git a/ash/common/shelf/overflow_button.cc b/ash/common/shelf/overflow_button.cc

index 6a8585750c7b971d02bd366fab49fbebf2915ea9..0e2c835a3707eef7f672711aa49280c78c58994b 100644

--- a/ash/common/shelf/overflow_button.cc

+++ b/ash/common/shelf/overflow_button.cc

@@ -128,7 +128,7 @@ void OverflowButton::PaintForeground(gfx::Canvas* canvas,

int OverflowButton::NonMaterialBackgroundImageId() {

if (wm_shelf_->IsShowingOverflowBubble())

return IDR_AURA_NOTIFICATION_BACKGROUND_PRESSED;

- else if (wm_shelf_->IsDimmed())

+ else if (wm_shelf_->GetBackgroundType() == SHELF_BACKGROUND_MAXIMIZED)

return IDR_AURA_NOTIFICATION_BACKGROUND_ON_BLACK;

return IDR_AURA_NOTIFICATION_BACKGROUND_NORMAL;

}

« no previous file with comments | « ash/common/shelf/app_list_button.cc ('k') | ash/common/shelf/wm_shelf.h » ('j') | no next file with comments »