Fix Volume slider is captured in screenshot done in touchview mode

chromeos/audio/cras_audio_handler.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_AUDIO_CRAS_AUDIO_HANDLER_H_
 #define CHROMEOS_AUDIO_CRAS_AUDIO_HANDLER_H_
 
 #include <stddef.h>
 #include <stdint.h>
 #include <queue>
@@ skipping 141 matching lines @@
   virtual bool GetPrimaryActiveOutputDevice(AudioDevice* device) const;
 
   // Whether there is alternative input/output audio device.
   virtual bool has_alternative_input() const;
   virtual bool has_alternative_output() const;
 
   // Sets all active output devices' volume level to |volume_percent|, whose
   // range is from 0-100%.
   virtual void SetOutputVolumePercent(int volume_percent);
 
+  // Sets all active output devices' volume level to |volume_percent|, whose

[Daniel Erat, 2016/07/28 23:57:53]

nit: s/level/levels/

[Qiang(Joe) Xu, 2016/07/29 04:30:32]

Done.

+  // range is from 0-100%, but indicating that this will not notify observers.

[Daniel Erat, 2016/07/28 23:57:52]

nit: change "but indicating that this will not notify observers." to "without
notifying observers."

[Qiang(Joe) Xu, 2016/07/29 04:30:32]

Done.

+  virtual void SetOutputVolumePercentInQuietMode(int volume_percent);

[Daniel Erat, 2016/07/28 23:57:52]

"InQuietMode" seems a bit confusing, since we're already dealing with volume
here. how about something like SetOutputVolumePercentWithoutNotifying() or
WithoutNotifyingObservers()?

or maybe even just add a "notify_observers" bool parameter to
SetOutputVolumePercent(), if jenny's okay with it.

[Qiang(Joe) Xu, 2016/07/29 04:30:32]

done by adding SetOutputVolumePercentWithoutNotifyingObservers. I will discuss
with jenny offline.

+
   // Sets all active input devices' gain level to |gain_percent|, whose range is
   // from 0-100%.
   virtual void SetInputGainPercent(int gain_percent);
 
   // Adjusts all active output devices' volume up (positive percentage) or down
   // (negative percentage).
   virtual void AdjustOutputVolumeByPercent(int adjust_by_percent);
 
   // Adjusts all active output devices' volume to a minimum audible level if it
   // is too low.
@@ skipping 253 matching lines @@
   // Failures are not logged at startup, since CRAS may not be running yet.
   bool log_errors_;
 
   // Timer for HDMI re-discovering grace period.
   base::OneShotTimer hdmi_rediscover_timer_;
   int hdmi_rediscover_grace_period_duration_in_ms_;
   bool hdmi_rediscovering_;
 
   bool cras_service_available_ = false;
 
-  bool initializing_audio_state_ = false;
+  // A mask to indicate if a volume change is initiated by user.

[Daniel Erat, 2016/07/28 23:57:53]

nit: document "A mask of NonUserVolumeChangeReason to indicate ..." (but see
naming suggestion in .cc)

[Qiang(Joe) Xu, 2016/07/29 04:30:32]

Done.

+  int volume_change_not_by_user_ = 0;

[Daniel Erat, 2016/07/28 23:57:53]

nit: non_user_volume_change_reasons_; (but see naming suggestion in .cc)

[Qiang(Joe) Xu, 2016/07/29 04:30:32]

Done.

+
   int init_volume_;
   uint64_t init_node_id_;
   int init_volume_count_ = 0;
 
   base::WeakPtrFactory<CrasAudioHandler> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(CrasAudioHandler);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROMEOS_AUDIO_CRAS_AUDIO_HANDLER_H_