Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: chromeos/audio/cras_audio_handler.h

Issue 2190773002: Fix Volume slider is captured in screenshot done in touchview mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: not using default parameter Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/audio/cras_audio_handler.h
diff --git a/chromeos/audio/cras_audio_handler.h b/chromeos/audio/cras_audio_handler.h
index c9110718e4a332a7bc0dde2b5a02d446857a8e2f..b95bb9747779fe29837ce44370ef64aa06b6b6ce 100644
--- a/chromeos/audio/cras_audio_handler.h
+++ b/chromeos/audio/cras_audio_handler.h
@@ -159,6 +159,10 @@ class CHROMEOS_EXPORT CrasAudioHandler : public CrasAudioClient::Observer,
// range is from 0-100%.
virtual void SetOutputVolumePercent(int volume_percent);
+ // Sets all active output devices' volume level to |volume_percent|, whose
Daniel Erat 2016/07/28 23:57:53 nit: s/level/levels/
Qiang(Joe) Xu 2016/07/29 04:30:32 Done.
+ // range is from 0-100%, but indicating that this will not notify observers.
Daniel Erat 2016/07/28 23:57:52 nit: change "but indicating that this will not not
Qiang(Joe) Xu 2016/07/29 04:30:32 Done.
+ virtual void SetOutputVolumePercentInQuietMode(int volume_percent);
Daniel Erat 2016/07/28 23:57:52 "InQuietMode" seems a bit confusing, since we're a
Qiang(Joe) Xu 2016/07/29 04:30:32 done by adding SetOutputVolumePercentWithoutNotify
+
// Sets all active input devices' gain level to |gain_percent|, whose range is
// from 0-100%.
virtual void SetInputGainPercent(int gain_percent);
@@ -432,7 +436,9 @@ class CHROMEOS_EXPORT CrasAudioHandler : public CrasAudioClient::Observer,
bool cras_service_available_ = false;
- bool initializing_audio_state_ = false;
+ // A mask to indicate if a volume change is initiated by user.
Daniel Erat 2016/07/28 23:57:53 nit: document "A mask of NonUserVolumeChangeReason
Qiang(Joe) Xu 2016/07/29 04:30:32 Done.
+ int volume_change_not_by_user_ = 0;
Daniel Erat 2016/07/28 23:57:53 nit: non_user_volume_change_reasons_; (but see nam
Qiang(Joe) Xu 2016/07/29 04:30:32 Done.
+
int init_volume_;
uint64_t init_node_id_;
int init_volume_count_ = 0;

Powered by Google App Engine
This is Rietveld 408576698