Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2190733003: webgl: Zero-initialize the SyncToken before calling GenSyncTokenCHROMIUM (Closed)

Created:
4 years, 4 months ago by danakj
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

webgl: Zero-initialize the SyncToken before calling GenSyncTokenCHROMIUM The GenSyncTokenCHROMIUM function may fail if it generates an error, or the context already has an error on it. At that point the sync token will not be updated, so we should have it initialized to 0 for this case. R=kbr@chromium.org BUG=629008 Review-Url: https://codereview.chromium.org/2162673002 Cr-Commit-Position: refs/heads/master@{#406162} (cherry picked from commit cf09bfc276420cce16b406380b6eeefb35ec8cbd) Committed: https://chromium.googlesource.com/chromium/src/+/206672866b790d414a38714e944873ca709b79ef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
danakj
Committed patchset #1 (id:1) manually as 206672866b790d414a38714e944873ca709b79ef.
4 years, 4 months ago (2016-07-27 21:43:12 UTC) #2
Ken Russell (switch to Gerrit)
LGTM after the fact.
4 years, 4 months ago (2016-08-02 21:59:22 UTC) #3
danakj
4 years, 4 months ago (2016-08-02 22:02:02 UTC) #4
Message was sent while issue was closed.
On Tue, Aug 2, 2016 at 2:59 PM, <kbr@chromium.org> wrote:

> LGTM after the fact.
>

(Just in case, this was just a merge to the branch)


>
>
> https://codereview.chromium.org/2190733003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698