webgl: Zero-initialize the SyncToken before calling GenSyncTokenCHROMIUM

webgl: Zero-initialize the SyncToken before calling GenSyncTokenCHROMIUM

The GenSyncTokenCHROMIUM function may fail if it generates an error, or
the context already has an error on it. At that point the sync token
will not be updated, so we should have it initialized to 0 for this
case.

R=kbr@chromium.org
BUG=629008
Committed: https://crrev.com/cf09bfc276420cce16b406380b6eeefb35ec8cbd
Cr-Commit-Position: refs/heads/master@{#406162}

[danakj, 2016-07-18 20:51:10]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 20:52:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Russell (switch to Gerrit), 2016-07-18 21:27:05]

lgtm

https://codereview.chromium.org/2162673002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp (right):

https://codereview.chromium.org/2162673002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp:572: GLbyte
syncToken[24] = { 0 };
Is this code allowed to reference src/gpu/GLES2/gl2extchromium.h at this point?
It would be preferable to change the "24" to GL_SYNC_TOKEN_SIZE_CHROMIUM.

[danakj, 2016-07-18 21:40:25]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-07-18 21:40:25]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/2162673002/#ps20001
(title: "zeroinit-synctoken: size")

[danakj, 2016-07-18 21:40:35]

https://codereview.chromium.org/2162673002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp (right):

https://codereview.chromium.org/2162673002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp:572: GLbyte
syncToken[24] = { 0 };
On 2016/07/18 21:27:05, Ken Russell wrote:
> Is this code allowed to reference src/gpu/GLES2/gl2extchromium.h at this
point?
> It would be preferable to change the "24" to GL_SYNC_TOKEN_SIZE_CHROMIUM.

Done. Thanks, didn't know that exists.

[commit-bot: I haz the power, 2016-07-18 21:40:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 00:40:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-19 00:40:44]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-19 00:41:45]

Description was changed from

==========
webgl: Zero-initialize the SyncToken before calling GenSyncTokenCHROMIUM

The GenSyncTokenCHROMIUM function may fail if it generates an error, or
the context already has an error on it. At that point the sync token
will not be updated, so we should have it initialized to 0 for this
case.

R=kbr@chromium.org
BUG=629008
==========

to

==========
webgl: Zero-initialize the SyncToken before calling GenSyncTokenCHROMIUM

The GenSyncTokenCHROMIUM function may fail if it generates an error, or
the context already has an error on it. At that point the sync token
will not be updated, so we should have it initialized to 0 for this
case.

R=kbr@chromium.org
BUG=629008

Committed: https://crrev.com/cf09bfc276420cce16b406380b6eeefb35ec8cbd
Cr-Commit-Position: refs/heads/master@{#406162}
==========

[commit-bot: I haz the power, 2016-07-19 00:41:47]

Patchset 2 (id:??) landed as
https://crrev.com/cf09bfc276420cce16b406380b6eeefb35ec8cbd
Cr-Commit-Position: refs/heads/master@{#406162}