Add bookmark provider for content suggestions

chrome/browser/profiles/profile_manager.cc

Index: chrome/browser/profiles/profile_manager.cc
diff --git a/chrome/browser/profiles/profile_manager.cc b/chrome/browser/profiles/profile_manager.cc
index 09c2b0f137c78f9c521cdc59f9352b75c78b0936..211cee24159a1e6b6a689142b3022bb3dd794724 100644
--- a/chrome/browser/profiles/profile_manager.cc
+++ b/chrome/browser/profiles/profile_manager.cc
@@ -107,6 +107,7 @@
 #endif
 
 #if defined(OS_ANDROID)
+#include "chrome/browser/android/ntp/bookmark_suggestions_provider_factory.h"
 #include "chrome/browser/android/ntp/offline_page_suggestions_provider_factory.h"
 #include "chrome/browser/ntp_snippets/content_suggestions_service_factory.h"
 #include "chrome/browser/ntp_snippets/ntp_snippets_service_factory.h"
@@ -1231,6 +1232,7 @@ void ProfileManager::DoFinalInitForServices(Profile* profile,
   ContentSuggestionsServiceFactory::GetForProfile(profile);
   NTPSnippetsServiceFactory::GetForProfile(profile);
   OfflinePageSuggestionsProviderFactory::GetForProfile(profile);
+  BookmarkSuggestionsProviderFactory::GetForProfile(profile);

[Bernhard Bauer, 2016/07/29 10:28:51]

Can we please not add any more initialization code here? Contrary to what seems
to be public opinion, this is not the place where every single profile-keyed
service should be initialized. By default, profile-keyed services are lazily
created when needed. If there is something that needs to happen at startup (like
scheduling the fetching task), the factory can declare that it wants to be
created with the profile. If we want to only add some providers under certain
conditions, we can move the provider registration code e.g. to the
ContentSuggestionsFactory, which would have the advantage that it would
centralize it.

[jkrcal, 2016/07/29 13:57:17]

Oh, did not know. Philipp is working on a CL that will move the
ContentSuggestionsServiceFactory to the components code. Maybe he can move both
the initialization lines away with that CL?

[Bernhard Bauer, 2016/07/29 14:32:42]

You mean all four? :)

If you absolutely can't get rid of the initialization in this CL, can you add a
TODO to remove them, and a comment that people should not add any more
initialization here?

[jkrcal, 2016/07/29 16:09:56]

I am leaving for vacation. Did not manage to finish it. I added this TODO
comment for the time being.

 #endif
 }