Add bookmark provider for content suggestions

chrome/browser/profiles/profile_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_manager.h"
 
 #include <stdint.h>
 
 #include <set>
 #include <string>
@@ skipping 89 matching lines @@
 #endif
 
 #if defined(ENABLE_SUPERVISED_USERS)
 #include "chrome/browser/supervised_user/child_accounts/child_account_service.h"
 #include "chrome/browser/supervised_user/child_accounts/child_account_service_factory.h"
 #include "chrome/browser/supervised_user/supervised_user_service.h"
 #include "chrome/browser/supervised_user/supervised_user_service_factory.h"
 #endif
 
 #if defined(OS_ANDROID)
+#include "chrome/browser/android/ntp/bookmark_suggestions_provider_factory.h"
 #include "chrome/browser/android/ntp/offline_page_suggestions_provider_factory.h"
 #include "chrome/browser/ntp_snippets/content_suggestions_service_factory.h"
 #include "chrome/browser/ntp_snippets/ntp_snippets_service_factory.h"
 #endif
 
 #if defined(OS_CHROMEOS)
 #include "chrome/browser/browser_process_platform_part_chromeos.h"
 #include "chrome/browser/chromeos/profiles/profile_helper.h"
 #include "chromeos/chromeos_switches.h"
 #include "chromeos/dbus/cryptohome_client.h"
@@ skipping 1104 matching lines @@
   // migration will be performed for all users it's planned to remove the
   // migration code, rough time estimates are Q1 2016.
   PasswordManagerSettingMigratorServiceFactory::GetForProfile(profile)
       ->InitializeMigration(ProfileSyncServiceFactory::GetForProfile(profile));
 
 #if defined(OS_ANDROID)
   // Service is responsible for fetching content snippets for the NTP.
   ContentSuggestionsServiceFactory::GetForProfile(profile);
   NTPSnippetsServiceFactory::GetForProfile(profile);
   OfflinePageSuggestionsProviderFactory::GetForProfile(profile);
+  BookmarkSuggestionsProviderFactory::GetForProfile(profile);

[Bernhard Bauer, 2016/07/29 10:28:51]

Can we please not add any more initialization code here? Contrary to what seems
to be public opinion, this is not the place where every single profile-keyed
service should be initialized. By default, profile-keyed services are lazily
created when needed. If there is something that needs to happen at startup (like
scheduling the fetching task), the factory can declare that it wants to be
created with the profile. If we want to only add some providers under certain
conditions, we can move the provider registration code e.g. to the
ContentSuggestionsFactory, which would have the advantage that it would
centralize it.

[jkrcal, 2016/07/29 13:57:17]

Oh, did not know. Philipp is working on a CL that will move the
ContentSuggestionsServiceFactory to the components code. Maybe he can move both
the initialization lines away with that CL?

[Bernhard Bauer, 2016/07/29 14:32:42]

You mean all four? :)

If you absolutely can't get rid of the initialization in this CL, can you add a
TODO to remove them, and a comment that people should not add any more
initialization here?

[jkrcal, 2016/07/29 16:09:56]

I am leaving for vacation. Did not manage to finish it. I added this TODO
comment for the time being.

 #endif
 }
 
 void ProfileManager::DoFinalInitLogging(Profile* profile) {
   TRACE_EVENT0("browser", "ProfileManager::DoFinalInitLogging");
   // Count number of extensions in this profile.
   int enabled_app_count = -1;
 #if defined(ENABLE_EXTENSIONS)
   enabled_app_count = GetEnabledAppCount(profile);
 #endif
@@ skipping 387 matching lines @@
 
   FinishDeletingProfile(profile_to_delete_path, new_active_profile_path);
   if (!original_callback.is_null())
     original_callback.Run(loaded_profile, status);
 }
 #endif  // !defined(OS_ANDROID)
 
 ProfileManagerWithoutInit::ProfileManagerWithoutInit(
     const base::FilePath& user_data_dir) : ProfileManager(user_data_dir) {
 }